-
-
Notifications
You must be signed in to change notification settings - Fork 797
Closed
Labels
Milestone
Description
The feathers-hooks plugin has become such an essential part of Feathers that it should probably become a core dependency. A good time to implement this is when removing callback support in both, hooks and services in Feathers v3.
This would also allow us to improve the service event dispatching by turning it into a hook (that always runs last) instead of a separate mixin (where the same functionality is currently provided by a different dependency Rubberduck).
Related issues:
hook.appis undefined in Event filters #405 and Create an app reference on service event hook object #406 are related to this but not completely solve the problem because thehookobject in a service event is not the same as during the method call (which it should be).- Hooks do not apply for realtime events #376 can also be solved with this since it would then allow us to set the data that need to be dispatched in the hook
- Also addresses Event channels/rooms #388 (specifically Event channels/rooms #388 (comment)) since you can set the dispatch data already in the hook which also allows to simplify and make event filtering more performant.
Reactions are currently unavailable