fix(core): context.path is now typed correctly#3303
Merged
daffl merged 1 commit intofeathersjs:dovefrom Oct 11, 2023
Merged
Conversation
daffl
approved these changes
Oct 11, 2023
Member
|
That's a great change, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
app.service()is typed to all the registered services, and sincecontext.pathis just a string doingapp.service(context.path)in a hook leads to an error that string is not assignable to<list of schemas>This issue resolve that by allow
context.pathto check against the service provided in theHookContext. IfHookContextis not typed with a service, it will default back to all services.If you create a hook in your user service. Where the
context.pathshould always beuser. It should not be typed as suchIf you create a global hook,
context.pathwill be a intersection of all your registered services.