feat(cli): Generate full client test suite and improve typed client#2788
Merged
feat(cli): Generate full client test suite and improve typed client#2788
Conversation
d82049f to
7fad31c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a test suite for the typed client to the generated application and moves the authentication tests into the client test suite. This helps to ensure that the typed client is fully functional and makes it easy to create full integration tests for an app. It also improves the typed client to dynamically import the actual service signature instead of using a generic interface.
Should close #2775
It also ensures that a standard app can be restarted. Previously, routes got removed on
teardowninstead ofunusewhich cause services to be no longer discoverable when the app is restarted (via.teardown()and then calling.setup()) again. The authentication service was also initialising its hooks twice in that case.