feat(core): add context.http and move statusCode there#2496
Merged
daffl merged 1 comm
8000
it intofeathersjs:dovefrom Nov 26, 2021
Merged
feat(core): add context.http and move statusCode there#2496daffl merged 1 commit intofeathersjs:dovefrom
context.http and move statusCode there#2496daffl merged 1 commit intofeathersjs:dovefrom
Conversation
daffl
reviewed
Nov 25, 2021
Member
There was a problem hiding this comment.
This looks good, thank you! Just two small somments.
e5161da to
e6ba761
Compare
Member
|
You can still set the status code, however it will be ignored for websockets since they have no effect. Feathers errors will still be converted with their respective error statuses though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is
context.httpfrom #2484.Here it contains only
statusCode(can be renamed tostatusor not, don't have an opinion one way or another so kept previous name), with the idea to addresponseHeaderslater (redirectis not needed since it will be covered by those two).I used getter/setter to prevent having two sources of truth and things getting out of sync. Also ideally a depreciation message should be added to those accessors that will write a warning first time one of them is accessed (a helper function for such depreciations can be added to
@feathersjs/commons).