fix: Resolve some type problems#2260
Merged
daffl merged 1 commit intofeathersjs:dovefrom Mar 22, 2021
Merged
Conversation
Member
|
Perfect, thank you! I was actually wondering why it was working before, too when I was looking into it. This looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #1566.
Don't know why types started to fail only after my changes, but i found and fixed reason for failures:
In
LegacyHookFunctionappproperty on potentially returned context was required to be of the same type as on passed in context. And because of this it was creating variance problems between simple feathers app and express wrapped app, through such forbidden chain:Since we don't care about returned context, simply relaxed type there. In turn such relaxation allowed to improve type of options in
hooksmethod of app itself (and not on service through which the problem was exposed).Other bonus small changes:
Updated
ExpressUseHandleras you mentioned. I missed that one, but it was not a cause for the failings. Also created separate overload for whenpathis a regexp.Keep
ServiceTypesandAppSettingsfrom feathers app during express wrapping.In
app.use| Applicationshould be inside ternary expression, not outside.