Build crash since v4.5.9: Type 'P' does not satisfy the constraint 'Params'. #2111
Description
Since this update diff:
diff --git a/package.json b/package.json
index bd1abdf..0928a1b 100644
--- a/package.json
+++ b/package.json
@@ -34,27 +34,27 @@
},
"types": "lib/",
"dependencies": {
- "@feathersjs/authentication": "^4.5.8",
- "@feathersjs/authentication-local": "^4.5.8",
- "@feathersjs/authentication-oauth": "^4.5.8",
- "@feathersjs/configuration": "^4.5.8",
- "@feathersjs/errors": "^4.5.8",
- "@feathersjs/express": "^4.5.8",
- "@feathersjs/feathers": "^4.5.8",
- "@feathersjs/socketio": "^4.5.8",
- "@feathersjs/transport-commons": "^4.5.8",
- "@googlemaps/google-maps-services-js": "^3.1.8",
+ "@feathersjs/authentication": "^4.5.9",
+ "@feathersjs/authentication-local": "^4.5.9",
+ "@feathersjs/authentication-oauth": "^4.5.9",
+ "@feathersjs/configuration": "^4.5.9",
+ "@feathersjs/errors": "^4.5.9",
+ "@feathersjs/express": "^4.5.9",
+ "@feathersjs/feathers": "^4.5.9",
+ "@feathersjs/socketio": "^4.5.9",
+ "@feathersjs/transport-commons": "^4.5.9",
+ "@googlemaps/google-maps-services-js": "^3.1.13",
"@hapi/joi": "^16.1.8",
"compression": "^1.7.4",
"cors": "^2.8.5",
- "date-holidays": "^1.6.2",
+ "date-holidays": "^1.7.1",
"feathers-hooks-common": "^5.0.4",
"feathers-nedb": "^5.1.0",
"google-libphonenumber": "^3.2.13",
"handlebars": "^4.7.6",
"helmet": "^3.23.3",
"mangopay2-nodejs-sdk": "^1.14.2",
- "moment": "^2.29.0",
+ "moment": "^2.29.1",
"moment-timezone": "^0.5.31",
"nedb": "^1.8.0",
"nexmo": "^2.9.1",The npm run build job (shx rm -rf lib/ && tsc) fails with the following errors:
node_modules/@feathersjs/express/node_modules/@types/express/index.d.ts:99:42 - error TS2344: Type 'P' does not satisfy the constraint 'Params'.
Type 'P' is not assignable to type 'ParamsArray'.
99 extends core.ErrorRequestHandler<P, ResBody, ReqBody, ReqQuery> { }
~
node_modules/@feathersjs/express/node_modules/@types/express/index.d.ts:108:124 - error TS2344: Type 'P' does not satisfy the constraint 'Params'.
Type 'P' is not assignable to type 'ParamsArray'.
108 interface Request<P = core.ParamsDictionary, ResBody = any, ReqBody = any, ReqQuery = core.Query> extends core.Request<P, ResBody, ReqBody, ReqQuery> { }
~
node_modules/@feathersjs/express/node_modules/@types/express/index.d.ts:109:138 - error TS2344: Type 'P' does not satisfy the constraint 'Params'.
Type 'P' is not assignable to type 'ParamsArray'.
109 interface RequestHandler<P = core.ParamsDictionary, ResBody = any, ReqBody = any, ReqQuery = core.Query> extends core.RequestHandler<P, ResBody, ReqBody, ReqQuery> { }
~
Looks like a BC break to me, all is working great with the previous version.