8000 feat: Remove (hook, next) signature and SKIP support by daffl · Pull Request #1269 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

feat: Remove (hook, next) signature and SKIP support#1269

Merged
daffl merged 5 commits intomasterfrom
remove-next-skip
Apr 3, 2019
Merged

feat: Remove (hook, next) signature and SKIP support#1269
daffl merged 5 commits intomasterfrom
remove-next-skip

Conversation

@daffl
Copy link
Member
@daffl daffl commented Apr 3, 2019 •
edited
Loading

In preparation to support Koa style hooks (see #932) this pull request

  • Removes the (context, next) signature. This has not been documented or used since the Auk release.
  • Removes feathers.SKIP to skip the following hooks. It turned out to cause issues because
    • It is not easily possible to see if a hook makes its following hooks skip. This made hook chains very hard to debug.
    • Returning SKIP also messes with Feathers internals like the event system

The use-cases for feathers.SKIP can now be explicitly handled by

@daffl daffl merged commit 211c0f8 into master Apr 3, 2019
@daffl daffl deleted the remove-next-skip branch April 3, 2019 17:29
@deskoh deskoh mentioned this pull request Apr 15, 2019
Closed
@tedhuang tedhuang mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daffl
0