diff --git a/changelog.md b/changelog.md index ab4b8b3af5..0523d71bd2 100644 --- a/changelog.md +++ b/changelog.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) + + +### Bug Fixes + +* Add info to express error handler logger type ([#1557](https://github.com/feathersjs/feathers/issues/1557)) ([3e1d26c](https://github.com/feathersjs/feathers/commit/3e1d26c)) +* LocalStrategy authenticates without username ([#1560](https://github.com/feathersjs/feathers/issues/1560)) ([2b258fd](https://github.com/feathersjs/feathers/commit/2b258fd)), closes [#1559](https://github.com/feathersjs/feathers/issues/1559) + + + + + ## [4.3.1](https://github.com/feathersjs/feathers/compare/v4.3.0...v4.3.1) (2019-09-09) diff --git a/lerna.json b/lerna.json index 5d6a03e5c7..4a7314cead 100644 --- a/lerna.json +++ b/lerna.json @@ -3,7 +3,7 @@ "packages": [ "packages/*" ], - "version": "4.3.2", + "version": "4.3.3", "command": { "bootstrap": { "hoist": true diff --git a/packages/adapter-commons/CHANGELOG.md b/packages/adapter-commons/CHANGELOG.md index 59b7a68fb9..7d395466d9 100644 --- a/packages/adapter-commons/CHANGELOG.md +++ b/packages/adapter-commons/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/adapter-commons + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/adapter-commons diff --git a/packages/adapter-commons/package.json b/packages/adapter-commons/package.json index 9f1bf438ff..8ea23df3d6 100644 --- a/packages/adapter-commons/package.json +++ b/packages/adapter-commons/package.json @@ -1,6 +1,6 @@ { "name": "@feathersjs/adapter-commons", - "version": "4.3.2", + "version": "4.3.3", "description": "Shared database adapter utility functions", "homepage": "https://feathersjs.com", "keywords": [ @@ -38,8 +38,8 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/errors": "^4.3.2", - "@feathersjs/feathers": "^4.3.2" + "@feathersjs/errors": "^4.3.3", + "@feathersjs/feathers": "^4.3.3" }, "devDependencies": { "@types/mocha": "^5.2.7", diff --git a/packages/adapter-tests/CHANGELOG.md b/packages/adapter-tests/CHANGELOG.md index 5fd36a0bf7..a4e48d054a 100644 --- a/packages/adapter-tests/CHANGELOG.md +++ b/packages/adapter-tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/adapter-tests + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/adapter-tests diff --git a/packages/adapter-tests/package.json b/packages/adapter-tests/package.json index 303872ba57..55cd8e6d58 100644 --- a/packages/adapter-tests/package.json +++ b/packages/adapter-tests/package.json @@ -1,6 +1,6 @@ { "name": "@feathersjs/adapter-tests", - "version": "4.3.2", + "version": "4.3.3", "description": "Feathers shared database adapter test suite", "homepage": "https://feathersjs.com", "keywords": [ @@ -34,8 +34,8 @@ "access": "public" }, "devDependencies": { - "@feathersjs/errors": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", "feathers-memory": "^4.0.0", "mocha": "^6.2.0" }, diff --git a/packages/authentication-client/CHANGELOG.md b/packages/authentication-client/CHANGELOG.md index 97608ac431..1f9ca7f82f 100644 --- a/packages/authentication-client/CHANGELOG.md +++ b/packages/authentication-client/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/authentication-client diff --git a/packages/authentication-client/package.json b/packages/authentication-client/package.json index c435b41067..6539a0a417 100644 --- a/packages/authentication-client/package.json +++ b/packages/authentication-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-client", "description": "The authentication plugin for feathers-client", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -39,20 +39,20 @@ "access": "public" }, "dependencies": { + "@feathersjs/authentication": "^4.3.3", "@feathersjs/commons": "^4.3.0", - "@feathersjs/errors": "^4.3.2", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", "debug": "^4.1.1" }, "devDependencies": { - "@feathersjs/authentication": "^4.3.2", - "@feathersjs/authentication-local": "^4.3.2", - "@feathersjs/express": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/primus": "^4.3.2", - "@feathersjs/primus-client": "^4.3.2", - "@feathersjs/rest-client": "^4.3.2", - "@feathersjs/socketio": "^4.3.2", - "@feathersjs/socketio-client": "^4.3.2", + "@feathersjs/authentication-local": "^4.3.3", + "@feathersjs/express": "^4.3.3", + "@feathersjs/primus": "^4.3.3", + "@feathersjs/primus-client": "^4.3.3", + "@feathersjs/rest-client": "^4.3.3", + "@feathersjs/socketio": "^4.3.3", + "@feathersjs/socketio-client": "^4.3.3", "@types/debug": "^4.1.5", "@types/mocha": "^5.2.7", "@types/node": "^12.7.2", diff --git a/packages/authentication-local/CHANGELOG.md b/packages/authentication-local/CHANGELOG.md index 86c7761e82..c94fc3b815 100644 --- a/packages/authentication-local/CHANGELOG.md +++ b/packages/authentication-local/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) diff --git a/packages/authentication-local/package.json b/packages/authentication-local/package.json index 907c54919b..3a2cea225f 100644 --- a/packages/authentication-local/package.json +++ b/packages/authentication-local/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-local", "description": "Local authentication strategy for @feathers/authentication", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -39,14 +39,14 @@ "access": "public" }, "dependencies": { - "@feathersjs/errors": "^4.3.2", + "@feathersjs/authentication": "^4.3.3", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", "bcryptjs": "^2.4.3", "debug": "^4.1.1", "lodash": "^4.17.15" }, "devDependencies": { - "@feathersjs/authentication": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", "@types/bcryptjs": "^2.4.2", "@types/debug": "^4.1.5", "@types/lodash": "^4.14.137", diff --git a/packages/authentication-oauth/CHANGELOG.md b/packages/authentication-oauth/CHANGELOG.md index 1abd2092c4..67dcc66456 100644 --- a/packages/authentication-oauth/CHANGELOG.md +++ b/packages/authentication-oauth/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/authentication-oauth diff --git a/packages/authentication-oauth/package.json b/packages/authentication-oauth/package.json index eff0fb7e06..c3cb8efe24 100644 --- a/packages/authentication-oauth/package.json +++ b/packages/authentication-oauth/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-oauth", "description": "oAuth 1 and 2 authentication for Feathers. Powered by Grant.", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -39,9 +39,10 @@ "access": "public" }, "dependencies": { - "@feathersjs/authentication": "^4.3.2", - "@feathersjs/errors": "^4.3.2", - "@feathersjs/express": "^4.3.2", + "@feathersjs/authentication": "^4.3.3", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/express": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", "debug": "^4.1.1", "express-session": "^1.16.2", "grant": "^4.6.2", @@ -49,7 +50,6 @@ "lodash": "^4.17.15" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", "@types/debug": "^4.1.5", "@types/express": "^4.17.1", "@types/express-session": "^1.15.14", diff --git a/packages/authentication-oauth/src/index.ts b/packages/authentication-oauth/src/index.ts index 9ba753b7fb..366bfbae3b 100644 --- a/packages/authentication-oauth/src/index.ts +++ b/packages/authentication-oauth/src/index.ts @@ -24,13 +24,13 @@ export const setup = (options: OauthSetupSettings) => (app: Application) => { } const { strategyNames } = service; - + // Set up all the defaults const { path = '/oauth' } = oauth.defaults || {}; const port = app.get('port'); let host = app.get('host'); let protocol = 'https'; - + // Development environments commonly run on HTTP with an extended port if (app.get('env') === 'development') { protocol = 'http'; @@ -38,7 +38,7 @@ export const setup = (options: OauthSetupSettings) => (app: Application) => { host += ':' + port; } } - + const grant = merge({ defaults: { path, @@ -47,7 +47,7 @@ export const setup = (options: OauthSetupSettings) => (app: Application) => { transport: 'session' } }, omit(oauth, 'redirect')); - + const getUrl = (url: string) => { const { defaults } = grant; return `${defaults.protocol}://${defaults.host}${path}/${url}`; diff --git a/packages/authentication/CHANGELOG.md b/packages/authentication/CHANGELOG.md index dbdde112e7..47aa28296d 100644 --- a/packages/authentication/CHANGELOG.md +++ b/packages/authentication/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* check for undefined access token ([#1571](https://github.com/feathersjs/feathers/issues/1571)) ([976369d](https://github.com/feathersjs/feathers/commit/976369d)) +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/authentication diff --git a/packages/authentication/package.json b/packages/authentication/package.json index be7d624cf8..ddc2c25820 100644 --- a/packages/authentication/package.json +++ b/packages/authentication/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication", "description": "Add Authentication to your FeathersJS app.", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -39,8 +39,9 @@ "access": "public" }, "dependencies": { - "@feathersjs/errors": "^4.3.2", - "@feathersjs/transport-commons": "^4.3.2", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/transport-commons": "^4.3.3", "debug": "^4.1.1", "jsonwebtoken": "^8.5.1", "lodash": "^4.17.15", @@ -48,7 +49,6 @@ "uuid": "^3.3.2" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", "@types/debug": "^4.1.5", "@types/jsonwebtoken": "^8.3.3", "@types/lodash": "^4.14.137", diff --git a/packages/authentication/src/jwt.ts b/packages/authentication/src/jwt.ts index 462fecd400..4fda2f9a68 100644 --- a/packages/authentication/src/jwt.ts +++ b/packages/authentication/src/jwt.ts @@ -32,8 +32,10 @@ export class JWTStrategy extends AuthenticationBaseStrategy { const isValidLogout = event === 'logout' && connection.authentication && authResult && connection.authentication.accessToken === authResult.accessToken; - if (authResult && event === 'login') { - const { accessToken } = authResult; + const { accessToken } = authResult || {}; + + if (accessToken && event === 'login') { + debug('Adding authentication information to connection'); const { exp } = await this.authentication.verifyAccessToken(accessToken); // The time (in ms) until the token expires const duration = (exp * 1000) - new Date().getTime(); diff --git a/packages/authentication/src/service.ts b/packages/authentication/src/service.ts index fc4b88de49..d6261be64e 100644 --- a/packages/authentication/src/service.ts +++ b/packages/authentication/src/service.ts @@ -92,15 +92,15 @@ export class AuthenticationService extends AuthenticationBase implements Partial debug('Got authentication result', authResult); + if (authResult.accessToken) { + return authResult; + } + const [ payload, jwtOptions ] = await Promise.all([ this.getPayload(authResult, params), this.getTokenOptions(authResult, params) ]); - if (authResult.accessToken) { - return authResult; - } - debug('Creating JWT with', payload, jwtOptions); const accessToken = await this.createAccessToken(payload, jwtOptions, params.secret); diff --git a/packages/client/CHANGELOG.md b/packages/client/CHANGELOG.md index 8dc20f6af6..c7ee87074c 100644 --- a/packages/client/CHANGELOG.md +++ b/packages/client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/client + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/client diff --git a/packages/client/package.json b/packages/client/package.json index fbfbf0a4d3..dd6a4e7e1d 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/client", "description": "A module that consolidates Feathers client modules for REST (jQuery, Request, Superagent) and Websocket (Socket.io, Primus) connections", - "version": "4.3.2", + "version": "4.3.3", "repository": { "type": "git", "url": "https://github.com/feathersjs/feathers.git" @@ -38,16 +38,16 @@ "@babel/core": "^7.5.5", "@babel/polyfill": "^7.4.4", "@babel/preset-env": "^7.5.5", - "@feathersjs/authentication-client": "^4.3.2", - "@feathersjs/errors": "^4.3.2", - "@feathersjs/express": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/primus": "^4.3.2", - "@feathersjs/primus-client": "^4.3.2", - "@feathersjs/rest-client": "^4.3.2", - "@feathersjs/socketio": "^4.3.2", - "@feathersjs/socketio-client": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/authentication-client": "^4.3.3", + "@feathersjs/errors": "^4.3.3", + "@feathersjs/express": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/primus": "^4.3.3", + "@feathersjs/primus-client": "^4.3.3", + "@feathersjs/rest-client": "^4.3.3", + "@feathersjs/socketio": "^4.3.3", + "@feathersjs/socketio-client": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "babel-loader": "^8.0.6", "body-parser": "^1.19.0", "feathers-memory": "^4.0.0", diff --git a/packages/configuration/CHANGELOG.md b/packages/configuration/CHANGELOG.md index 527e11e005..57c0f2d2d7 100644 --- a/packages/configuration/CHANGELOG.md +++ b/packages/configuration/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/configuration diff --git a/packages/configuration/package.json b/packages/configuration/package.json index 11273c4903..17c6ee475b 100644 --- a/packages/configuration/package.json +++ b/packages/configuration/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/configuration", "description": "A small configuration module for your Feathers application.", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -44,11 +44,11 @@ "access": "public" }, "dependencies": { + "@feathersjs/feathers": "^4.3.3", "config": "^3.2.2", "debug": "^4.1.1" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", "@types/config": "^0.0.34", "@types/debug": "^4.1.5", "@types/mocha": "^5.2.7", diff --git a/packages/configuration/src/index.ts b/packages/configuration/src/index.ts index 36e1ed15b5..4f6079a560 100644 --- a/packages/configuration/src/index.ts +++ b/packages/configuration/src/index.ts @@ -7,7 +7,7 @@ const debug = Debug('@feathersjs/configuration'); const separator = path.sep; export default function init () { - return (app: Application|undefined) => { + return (app?: Application) => { const convert = (current: any) => { const result: { [key: string]: any } = Array.isArray(current) ? [] : {}; @@ -53,7 +53,7 @@ export default function init () { Object.keys(conf).forEach(name => { const value = conf[name]; debug(`Setting ${name} configuration value to`, value); - (app as Application).set(name, value); + app!.set(name, value); }); return conf; diff --git a/packages/errors/CHANGELOG.md b/packages/errors/CHANGELOG.md index 12a9cf5a30..3ebeacc472 100644 --- a/packages/errors/CHANGELOG.md +++ b/packages/errors/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/errors + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/errors diff --git a/packages/errors/package.json b/packages/errors/package.json index e4759843ca..c6b1d04268 100644 --- a/packages/errors/package.json +++ b/packages/errors/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/errors", "description": "Common error types for Feathers apps", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/index", "types": "index.d.ts", @@ -39,7 +39,7 @@ "debug": "^4.1.1" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", + "@feathersjs/feathers": "^4.3.3", "chai": "^4.2.0", "express": "^4.17.1", "mocha": "^6.2.0", diff --git a/packages/express/CHANGELOG.md b/packages/express/CHANGELOG.md index 75be71920c..8510df31b2 100644 --- a/packages/express/CHANGELOG.md +++ b/packages/express/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/express + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) diff --git a/packages/express/package.json b/packages/express/package.json index d6668d64ff..54b44b7766 100644 --- a/packages/express/package.json +++ b/packages/express/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/express", "description": "Feathers Express framework bindings and REST provider", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -37,7 +37,7 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/errors": "^4.3.2", + "@feathersjs/errors": "^4.3.3", "@types/express": "^4.17.1", "debug": "^4.1.1", "express": "^4.17.1", @@ -45,10 +45,10 @@ "uberproto": "^2.0.4" }, "devDependencies": { - "@feathersjs/authentication": "^4.3.2", - "@feathersjs/authentication-local": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/authentication": "^4.3.3", + "@feathersjs/authentication-local": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "axios": "^0.19.0", "chai": "^4.2.0", "lodash": "^4.17.15", diff --git a/packages/feathers/CHANGELOG.md b/packages/feathers/CHANGELOG.md index d2f3df032e..67a1f82891 100644 --- a/packages/feathers/CHANGELOG.md +++ b/packages/feathers/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + + +### Bug Fixes + +* Small improvements in dependencies and code sturcture ([#1562](https://github.com/feathersjs/feathers/issues/1562)) ([42c13e2](https://github.com/feathersjs/feathers/commit/42c13e2)) + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/feathers diff --git a/packages/feathers/lib/application.js b/packages/feathers/lib/application.js index ec81c78ca6..92e89cf166 100644 --- a/packages/feathers/lib/application.js +++ b/packages/feathers/lib/application.js @@ -70,7 +70,7 @@ const application = { const current = this.services[location]; if (typeof current === 'undefined' && typeof this.defaultService === 'function') { - return this.use(`/${location}`, this.defaultService(location)) + return this.use(location, this.defaultService(location)) .service(location); } @@ -84,9 +84,7 @@ const application = { const location = stripSlashes(path) || '/'; const isSubApp = typeof service.service === 'function' && service.services; - const isService = this.methods.concat('setup').some(name => - (service && typeof service[name] === 'function') - ); + const isService = this.methods.concat('setup').some(name => typeof service[name] === 'function'); if (isSubApp) { const subApp = service; diff --git a/packages/feathers/lib/version.js b/packages/feathers/lib/version.js index 3c9d80de1d..a5301b6688 100644 --- a/packages/feathers/lib/version.js +++ b/packages/feathers/lib/version.js @@ -1 +1 @@ -module.exports = '4.3.1'; +module.exports = '4.3.2'; diff --git a/packages/feathers/package.json b/packages/feathers/package.json index b7d25dcae2..6762cdb4e2 100644 --- a/packages/feathers/package.json +++ b/packages/feathers/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/feathers", "description": "A framework for real-time applications and REST API with JavaScript and TypeScript", - "version": "4.3.2", + "version": "4.3.3", "homepage": "http://feathersjs.com", "repository": { "type": "git", diff --git a/packages/primus-client/CHANGELOG.md b/packages/primus-client/CHANGELOG.md index c62ba5d981..888c1ae06b 100644 --- a/packages/primus-client/CHANGELOG.md +++ b/packages/primus-client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/primus-client + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/primus-client diff --git a/packages/primus-client/package.json b/packages/primus-client/package.json index c2ff10a91f..edeb1cb65a 100644 --- a/packages/primus-client/package.json +++ b/packages/primus-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/primus-client", "description": "Client services for Primus and feathers-primus", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -36,13 +36,13 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.2" + "@feathersjs/transport-commons": "^4.3.3" }, "devDependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/primus": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/primus": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "chai": "^4.2.0", "feathers-memory": "^4.0.0", "mocha": "^6.2.0", diff --git a/packages/primus/CHANGELOG.md b/packages/primus/CHANGELOG.md index cc7a15a9d0..4341b0db51 100644 --- a/packages/primus/CHANGELOG.md +++ b/packages/primus/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/primus + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/primus diff --git a/packages/primus/package.json b/packages/primus/package.json index 6a0e156996..bf08ac20ce 100644 --- a/packages/primus/package.json +++ b/packages/primus/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/primus", "description": "The Feathers Primus real-time API provider", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -36,7 +36,7 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.2", + "@feathersjs/transport-commons": "^4.3.3", "debug": "^4.1.1", "primus": "^7.3.3", "primus-emitter": "^3.1.1", @@ -44,9 +44,9 @@ }, "devDependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/express": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/express": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "feathers-memory": "^4.0.0", "lodash": "^4.17.15", "mocha": "^6.2.0", diff --git a/packages/rest-client/CHANGELOG.md b/packages/rest-client/CHANGELOG.md index 5ed7437d38..d7c81e3dc0 100644 --- a/packages/rest-client/CHANGELOG.md +++ b/packages/rest-client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/rest-client + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/rest-client diff --git a/packages/rest-client/package.json b/packages/rest-client/package.json index 43282e5e56..67fb9243a5 100644 --- a/packages/rest-client/package.json +++ b/packages/rest-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/rest-client", "description": "REST client services for different Ajax libraries", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -37,7 +37,7 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/errors": "^4.3.2", + "@feathersjs/errors": "^4.3.3", "qs": "^6.8.0" }, "devDependencies": { @@ -45,9 +45,9 @@ "@angular/core": "^8.2.2", "@angular/http": "^7.2.15", "@angular/platform-browser": "^8.2.2", - "@feathersjs/express": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/express": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "axios": "^0.19.0", "body-parser": "^1.19.0", "feathers-memory": "^4.0.0", diff --git a/packages/socketio-client/CHANGELOG.md b/packages/socketio-client/CHANGELOG.md index 354321fdb8..0eaa7bb52d 100644 --- a/packages/socketio-client/CHANGELOG.md +++ b/packages/socketio-client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/socketio-client + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/socketio-client diff --git a/packages/socketio-client/package.json b/packages/socketio-client/package.json index eb245acef2..c5af739390 100644 --- a/packages/socketio-client/package.json +++ b/packages/socketio-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/socketio-client", "description": "The client for Socket.io through feathers-socketio", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -36,14 +36,14 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.2", + "@feathersjs/transport-commons": "^4.3.3", "@types/socket.io-client": "^1.4.32" }, "devDependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/socketio": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/socketio": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "chai": "^4.2.0", "feathers-memory": "^4.0.0", "mocha": "^6.2.0", diff --git a/packages/socketio/CHANGELOG.md b/packages/socketio/CHANGELOG.md index ef4b00174f..23fc80c8a9 100644 --- a/packages/socketio/CHANGELOG.md +++ b/packages/socketio/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/socketio + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/socketio diff --git a/packages/socketio/package.json b/packages/socketio/package.json index 5b614ff0d0..2c46891dcd 100644 --- a/packages/socketio/package.json +++ b/packages/socketio/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/socketio", "description": "The Feathers Socket.io real-time API provider", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -36,7 +36,7 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.2", + "@feathersjs/transport-commons": "^4.3.3", "@types/socket.io": "^2.1.2", "debug": "^4.1.1", "socket.io": "^2.2.0", @@ -44,9 +44,9 @@ }, "devDependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/express": "^4.3.2", - "@feathersjs/feathers": "^4.3.2", - "@feathersjs/tests": "^4.3.2", + "@feathersjs/express": "^4.3.3", + "@feathersjs/feathers": "^4.3.3", + "@feathersjs/tests": "^4.3.3", "feathers-memory": "^4.0.0", "lodash": "^4.17.15", "mocha": "^6.2.0", diff --git a/packages/tests/CHANGELOG.md b/packages/tests/CHANGELOG.md index c05bb1b899..3695970a24 100644 --- a/packages/tests/CHANGELOG.md +++ b/packages/tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/tests + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/tests diff --git a/packages/tests/package.json b/packages/tests/package.json index 7034eec7d5..32e17f76ae 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -2,7 +2,7 @@ "name": "@feathersjs/tests", "private": true, "description": "Feathers core module common tests", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "keywords": [ @@ -42,7 +42,7 @@ "lodash": "^4.17.15" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", + "@feathersjs/feathers": "^4.3.3", "@types/axios": "^0.14.0", "@types/debug": "^4.1.5", "@types/lodash": "^4.14.137", diff --git a/packages/transport-commons/CHANGELOG.md b/packages/transport-commons/CHANGELOG.md index 73d3621092..5e189ad0d1 100644 --- a/packages/transport-commons/CHANGELOG.md +++ b/packages/transport-commons/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.3](https://github.com/feathersjs/feathers/compare/v4.3.2...v4.3.3) (2019-09-21) + +**Note:** Version bump only for package @feathersjs/transport-commons + + + + + ## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16) **Note:** Version bump only for package @feathersjs/transport-commons diff --git a/packages/transport-commons/package.json b/packages/transport-commons/package.json index b44a6a11c6..a57830a13c 100644 --- a/packages/transport-commons/package.json +++ b/packages/transport-commons/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/transport-commons", "description": "Shared functionality for websocket providers", - "version": "4.3.2", + "version": "4.3.3", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -40,13 +40,13 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.0", - "@feathersjs/errors": "^4.3.2", + "@feathersjs/errors": "^4.3.3", "debug": "^4.1.1", "lodash": "^4.17.15", "radix-router": "^3.0.1" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.2", + "@feathersjs/feathers": "^4.3.3", "@types/debug": "^4.1.5", "@types/mocha": "^5.2.7", "@types/node": "^12.7.2",