From 42d81b26ea21b2fafb3c4a1d56f51c4a9e031c07 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Mon, 11 Nov 2019 09:08:34 -0800 Subject: [PATCH 01/10] chore: Update version and changelog --- changelog.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/changelog.md b/changelog.md index f811f995ea..1ed8f15482 100644 --- a/changelog.md +++ b/changelog.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) + + +### Bug Fixes + +* **authentication:** Retain object references in authenticate hook ([#1675](https://github.com/feathersjs/feathers/issues/1675)) ([e1939be](https://github.com/feathersjs/feathers/commit/e1939be19d4e79d3f5e2fe69ba894a11c627ae99)) +* **authentication-oauth:** Allow hash based redirects ([#1676](https://github.com/feathersjs/feathers/issues/1676)) ([ffe7cf3](https://github.com/feathersjs/feathers/commit/ffe7cf3fbb4e62d7689065cf7b61f25f602ce8cf)) + + + + + ## [4.3.10](https://github.com/feathersjs/feathers/compare/v4.3.9...v4.3.10) (2019-10-26) **Note:** Version bump only for package feathers From f5d0ddd9724bf5778355535d2103d59daaad6294 Mon Sep 17 00:00:00 2001 From: Desmond Koh Date: Fri, 22 Nov 2019 01:17:52 +0800 Subject: [PATCH 02/10] fix(typescript): Allow specific service typings for `Hook` and `HookContext` (#1688) --- packages/feathers/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts index 985a018c01..b48a914180 100644 --- a/packages/feathers/index.d.ts +++ b/packages/feathers/index.d.ts @@ -49,9 +49,9 @@ declare namespace createApplication { } // tslint:disable-next-line void-return - type Hook = (hook: HookContext) => (Promise | HookContext | void); + type Hook> = (hook: HookContext) => (Promise | void> | HookContext | void); - interface HookContext { + interface HookContext> { /** * A read only property that contains the Feathers application object. This can be used to * retrieve other services (via context.app.service('name')) or configuration values. @@ -101,7 +101,7 @@ declare namespace createApplication { /** * A read only property and contains the service this hook currently runs on. */ - readonly service: Service; + readonly service: S; /** * A writeable, optional property and contains a 'safe' version of the data that * should be sent to any client. If context.dispatch has not been set context.result From 395162633ff22e95833a3c2900cb9464bb5b056f Mon Sep 17 00:00:00 2001 From: David Luecke Date: Thu, 21 Nov 2019 09:18:09 -0800 Subject: [PATCH 03/10] fix(authentication-client): Reset authentication promise on socket disconnect (#1696) --- packages/authentication-client/src/core.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/authentication-client/src/core.ts b/packages/authentication-client/src/core.ts index 59cd8fdd63..77178872f4 100644 --- a/packages/authentication-client/src/core.ts +++ b/packages/authentication-client/src/core.ts @@ -61,14 +61,18 @@ export class AuthenticationClient { handleSocket (socket: any) { // Connection events happen on every reconnect const connected = this.app.io ? 'connect' : 'open'; + const disconnected = this.app.io ? 'disconnect' : 'disconnection'; - socket.on(connected, () => { + socket.on(disconnected, () => { + const authPromise = new Promise(resolve => + socket.once(connected, () => resolve()) + ) // Only reconnect when `reAuthenticate()` or `authenticate()` // has been called explicitly first - if (this.authenticated) { - // Force reauthentication with the server - this.reAuthenticate(true); - } + // Force reauthentication with the server + .then(() => this.authenticated ? this.reAuthenticate(true) : null); + + this.app.set('authentication', authPromise); }); } From 5f212729849414c4da6f0d51edd1986feca992ee Mon Sep 17 00:00:00 2001 From: Beau Shaw Date: Thu, 21 Nov 2019 11:29:40 -0600 Subject: [PATCH 04/10] fix(rest-client): Allow to customize getting the query (#1594) --- packages/rest-client/lib/base.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/rest-client/lib/base.js b/packages/rest-client/lib/base.js index 8e95f12e44..635b50bcd7 100644 --- a/packages/rest-client/lib/base.js +++ b/packages/rest-client/lib/base.js @@ -1,4 +1,4 @@ -const query = require('qs'); +const qs = require('qs'); const { Unavailable } = require('@feathersjs/errors'); const { _ } = require('@feathersjs/commons'); const { stripSlashes } = require('@feathersjs/commons'); @@ -20,21 +20,25 @@ class Base { this.base = `${settings.base}/${this.name}`; } - makeUrl (params, id) { - params = params || {}; + makeUrl (query, id) { + query = query || {}; let url = this.base; if (typeof id !== 'undefined' && id !== null) { url += `/${encodeURIComponent(id)}`; } - if (Object.keys(params).length !== 0) { - const queryString = query.stringify(params); + return url + this.getQuery(query); + } + + getQuery (query) { + if (Object.keys(query).length !== 0) { + const queryString = qs.stringify(query); - url += `?${queryString}`; + return `?${queryString}`; } - return url; + return ''; } find (params = {}) { From 2331c2a3dd70d432db7d62a76ed805d359cbbba5 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Tue, 26 Nov 2019 12:33:19 -0800 Subject: [PATCH 05/10] fix(core): Improve hook missing parameter message by adding the service name (#1703) --- packages/feathers/lib/hooks/base.js | 6 +++--- packages/feathers/test/hooks/hooks.test.js | 6 +++--- packages/rest-client/test/index.test.js | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/feathers/lib/hooks/base.js b/packages/feathers/lib/hooks/base.js index b044ea7983..bde4fea210 100644 --- a/packages/feathers/lib/hooks/base.js +++ b/packages/feathers/lib/hooks/base.js @@ -16,15 +16,15 @@ const assignArguments = context => { }; const validate = context => { - const { service, method } = context; + const { service, method, path } = context; const parameters = service.methods[method]; if (parameters.includes('id') && context.id === undefined) { - throw new Error(`An id must be provided to the '${method}' method`); + throw new Error(`An id must be provided to the '${path}.${method}' method`); } if (parameters.includes('data') && !_.isObjectOrArray(context.data)) { - throw new Error(`A data object must be provided to the '${method}' method`); + throw new Error(`A data object must be provided to the '${path}.${method}' method`); } return context; diff --git a/packages/feathers/test/hooks/hooks.test.js b/packages/feathers/test/hooks/hooks.test.js index 020fbf25b4..efe184c633 100644 --- a/packages/feathers/test/hooks/hooks.test.js +++ b/packages/feathers/test/hooks/hooks.test.js @@ -18,11 +18,11 @@ describe('hooks basics', () => { return app.service('dummy').get(); }).catch(e => { - assert.strictEqual(e.message, `An id must be provided to the 'get' method`); + assert.strictEqual(e.message, `An id must be provided to the 'dummy.get' method`); }).then(() => app.service('dummy').create() ).catch(e => { - assert.strictEqual(e.message, `A data object must be provided to the 'create' method`); + assert.strictEqual(e.message, `A data object must be provided to the 'dummy.create' method`); }); }); @@ -201,7 +201,7 @@ describe('hooks basics', () => { assert.strictEqual(context.service, app.service('dummy')); assert.strictEqual(context.type, 'error'); assert.strictEqual(context.path, 'dummy'); - assert.strictEqual(context.error.message, 'An id must be provided to the \'get\' method'); + assert.strictEqual(context.error.message, 'An id must be provided to the \'dummy.get\' method'); }); }); diff --git a/packages/rest-client/test/index.test.js b/packages/rest-client/test/index.test.js index 41c287f7c7..dd4eb06a2d 100644 --- a/packages/rest-client/test/index.test.js +++ b/packages/rest-client/test/index.test.js @@ -79,19 +79,19 @@ describe('REST client tests', function () { const service = app.service('todos'); return service.get().catch(error => { - assert.strictEqual(error.message, `An id must be provided to the 'get' method`); + assert.strictEqual(error.message, `An id must be provided to the 'todos.get' method`); return service.remove(); }).catch(error => { - assert.strictEqual(error.message, `An id must be provided to the 'remove' method`); + assert.strictEqual(error.message, `An id must be provided to the 'todos.remove' method`); return service.update(); }).catch(error => { - assert.strictEqual(error.message, `An id must be provided to the 'update' method`); + assert.strictEqual(error.message, `An id must be provided to the 'todos.update' method`); return service.patch(); }).catch(error => { - assert.strictEqual(error.message, `An id must be provided to the 'patch' method`); + assert.strictEqual(error.message, `An id must be provided to the 'todos.patch' method`); }); }); }); From a4aecbcd3578c1cf4ecffb3a58fb6d26e15ee513 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Wed, 27 Nov 2019 08:48:54 -0800 Subject: [PATCH 06/10] fix(transport-commons): Allow to properly chain SocketIo client.off (#1706) --- packages/transport-commons/src/client.ts | 4 +++- packages/transport-commons/test/client.test.ts | 9 +++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/transport-commons/src/client.ts b/packages/transport-commons/src/client.ts index adcdb8cdfa..6aec89790d 100644 --- a/packages/transport-commons/src/client.ts +++ b/packages/transport-commons/src/client.ts @@ -130,7 +130,9 @@ export class Service { // of the emitter-component Socket.io is using off (name: string, ...args: any[]) { if (typeof this.connection.off === 'function') { - return this.connection.off(`${this.path} ${name}`, ...args); + const result = this.connection.off(`${this.path} ${name}`, ...args); + + return result === this.connection ? this : result; } else if (args.length === 0) { // @ts-ignore return this.removeAllListeners(name); diff --git a/packages/transport-commons/test/client.test.ts b/packages/transport-commons/test/client.test.ts index 7a9e21f05f..a5d11af48f 100644 --- a/packages/transport-commons/test/client.test.ts +++ b/packages/transport-commons/test/client.test.ts @@ -204,14 +204,15 @@ describe('client', () => { connection.emit('todos test', testing); }); - it('forwards namespaced call to .off', done => { + it('forwards namespaced call to .off, returns service instance', () => { // Use it's own connection and service so off method gets detected const conn = new EventEmitter(); // @ts-ignore - conn.off = name => { + conn.off = function (name) { assert.strictEqual(name, 'todos test'); - done(); + + return this; }; const client = new Service({ @@ -221,6 +222,6 @@ describe('client', () => { connection: conn }); - client.off('test'); + assert.strictEqual(client.off('test'), client); }); }); From 18ba231f918ff9aef18e6c2f31a68e095c22b478 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Wed, 27 Nov 2019 08:55:07 -0800 Subject: [PATCH 07/10] chore: Update all Node engine versions --- package.json | 2 +- packages/adapter-commons/package.json | 2 +- packages/adapter-tests/package.json | 2 +- packages/authentication-client/package.json | 2 +- packages/authentication-local/package.json | 2 +- packages/authentication-oauth/package.json | 2 +- packages/authentication/package.json | 2 +- packages/client/package.json | 2 +- packages/commons/package.json | 2 +- packages/configuration/package.json | 2 +- packages/errors/package.json | 2 +- packages/express/package.json | 2 +- packages/feathers/package.json | 2 +- packages/primus-client/package.json | 2 +- packages/primus/package.json | 2 +- packages/rest-client/package.json | 2 +- packages/socketio-client/package.json | 2 +- packages/socketio/package.json | 2 +- packages/tests/package.json | 2 +- packages/transport-commons/package.json | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/package.json b/package.json index ad3575b78c..5288690f90 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 8" + "node": ">= 12" }, "scripts": { "install": "lerna bootstrap", diff --git a/packages/adapter-commons/package.json b/packages/adapter-commons/package.json index 8dc2d8a8c9..097765bfa4 100644 --- a/packages/adapter-commons/package.json +++ b/packages/adapter-commons/package.json @@ -25,7 +25,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "main": "lib/", "types": "lib/", diff --git a/packages/adapter-tests/package.json b/packages/adapter-tests/package.json index 54b1516288..8bc80e37bb 100644 --- a/packages/adapter-tests/package.json +++ b/packages/adapter-tests/package.json @@ -25,7 +25,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 8" + "node": ">= 12" }, "main": "lib/index.js", "scripts": { diff --git a/packages/authentication-client/package.json b/packages/authentication-client/package.json index aace1b4698..9ceff6d2f4 100644 --- a/packages/authentication-client/package.json +++ b/packages/authentication-client/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", diff --git a/packages/authentication-local/package.json b/packages/authentication-local/package.json index bcb5f02296..0d637db83d 100644 --- a/packages/authentication-local/package.json +++ b/packages/authentication-local/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", diff --git a/packages/authentication-oauth/package.json b/packages/authentication-oauth/package.json index 8503c18d54..2202e98da6 100644 --- a/packages/authentication-oauth/package.json +++ b/packages/authentication-oauth/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "start": "ts-node test/app", diff --git a/packages/authentication/package.json b/packages/authentication/package.json index 5b39e46831..f8225a4120 100644 --- a/packages/authentication/package.json +++ b/packages/authentication/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", diff --git a/packages/client/package.json b/packages/client/package.json index 4dbcc85d42..b6706ce3ee 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -21,7 +21,7 @@ ], "author": "Feathers contributors", "engines": { - "node": ">= 6" + "node": ">= 12" }, "main": "index.js", "types": "index.d.ts", diff --git a/packages/commons/package.json b/packages/commons/package.json index 48a3ceb24b..e00bb2909d 100644 --- a/packages/commons/package.json +++ b/packages/commons/package.json @@ -25,7 +25,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "main": "lib/", "types": "lib/", diff --git a/packages/configuration/package.json b/packages/configuration/package.json index d8a41d62c5..d38af37048 100644 --- a/packages/configuration/package.json +++ b/packages/configuration/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", diff --git a/packages/errors/package.json b/packages/errors/package.json index 4580a5c907..fc6904f649 100644 --- a/packages/errors/package.json +++ b/packages/errors/package.json @@ -24,7 +24,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "directories": { "lib": "lib" diff --git a/packages/express/package.json b/packages/express/package.json index 9de7d2229c..10316df9ca 100644 --- a/packages/express/package.json +++ b/packages/express/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/feathers/package.json b/packages/feathers/package.json index 9936bf70e0..3fe6919c0e 100644 --- a/packages/feathers/package.json +++ b/packages/feathers/package.json @@ -39,7 +39,7 @@ "publish": "npm run reset-version" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "publishConfig": { "access": "public" diff --git a/packages/primus-client/package.json b/packages/primus-client/package.json index f79511f3f4..87d0025896 100644 --- a/packages/primus-client/package.json +++ b/packages/primus-client/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6.0.0" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/primus/package.json b/packages/primus/package.json index c07f0f8981..c7e6380dd1 100644 --- a/packages/primus/package.json +++ b/packages/primus/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/rest-client/package.json b/packages/rest-client/package.json index 5282907aaa..ff0906b87c 100644 --- a/packages/rest-client/package.json +++ b/packages/rest-client/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6.0.0" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/socketio-client/package.json b/packages/socketio-client/package.json index 4d700f42b0..86a5b1eb6e 100644 --- a/packages/socketio-client/package.json +++ b/packages/socketio-client/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6.0.0" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/socketio/package.json b/packages/socketio/package.json index b26e333452..411ce7bf64 100644 --- a/packages/socketio/package.json +++ b/packages/socketio/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "test": "mocha --opts ../../mocha.opts" diff --git a/packages/tests/package.json b/packages/tests/package.json index 7b9b409a65..79f4f4f1af 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -27,7 +27,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", diff --git a/packages/transport-commons/package.json b/packages/transport-commons/package.json index eaf0bad06f..baeeccb1fe 100644 --- a/packages/transport-commons/package.json +++ b/packages/transport-commons/package.json @@ -28,7 +28,7 @@ "url": "https://github.com/feathersjs/feathers/issues" }, "engines": { - "node": ">= 6" + "node": ">= 12" }, "scripts": { "prepublish": "npm run compile", From 5e65629b924724c3e81d7c81df047e123d1c8bd7 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Wed, 27 Nov 2019 09:34:01 -0800 Subject: [PATCH 08/10] feat(authentication): Add parseStrategies to allow separate strategies for creating JWTs and parsing headers (#1708) --- packages/authentication-local/test/fixture.js | 1 + packages/express/lib/authentication.js | 5 +++-- packages/express/test/authentication.test.js | 3 ++- packages/socketio/lib/middleware.js | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/authentication-local/test/fixture.js b/packages/authentication-local/test/fixture.js index 7772bcdc1a..acbc34d765 100644 --- a/packages/authentication-local/test/fixture.js +++ b/packages/authentication-local/test/fixture.js @@ -13,6 +13,7 @@ module.exports = (app = feathers()) => { service: 'users', secret: 'supersecret', authStrategies: [ 'local', 'jwt' ], + parseStrategies: [ 'jwt' ], local: { usernameField: 'email', passwordField: 'password' diff --git a/packages/express/lib/authentication.js b/packages/express/lib/authentication.js index fc7276bf6b..991574f4c3 100644 --- a/packages/express/lib/authentication.js +++ b/packages/express/lib/authentication.js @@ -15,10 +15,11 @@ exports.parseAuthentication = (settings = {}) => { return next(); } - const { authStrategies = [] } = service.configuration; + const config = service.configuration; + const authStrategies = config.parseStrategies || config.authStrategies || []; if (authStrategies.length === 0) { - debug('No `authStrategies` found in authentication configuration'); + debug('No `authStrategies` or `parseStrategies` found in authentication configuration'); return next(); } diff --git a/packages/express/test/authentication.test.js b/packages/express/test/authentication.test.js index 6121413e1d..a96ba63d83 100644 --- a/packages/express/test/authentication.test.js +++ b/packages/express/test/authentication.test.js @@ -116,9 +116,10 @@ describe('@feathersjs/express/authentication', () => { }); }); - it('errors when there are no authStrategies', () => { + it('errors when there are no authStrategies and parseStrategies', () => { const { accessToken } = authResult; app.get('authentication').authStrategies = []; + delete app.get('authentication').parseStrategies; return axios.get('/dummy/dave', { headers: { diff --git a/packages/socketio/lib/middleware.js b/packages/socketio/lib/middleware.js index 1cbf289cbb..10f626621f 100644 --- a/packages/socketio/lib/middleware.js +++ b/packages/socketio/lib/middleware.js @@ -23,7 +23,8 @@ exports.authentication = (app, getParams, settings = {}) => (socket, next) => { return next(); } - const { authStrategies = [] } = service.configuration; + const config = service.configuration; + const authStrategies = config.parseStrategies || config.authStrategies || []; if (authStrategies.length === 0) { return next(); From 1293e088abbb3d23f4a44680836645a8049ceaae Mon Sep 17 00:00:00 2001 From: fadiquader Date: Thu, 28 Nov 2019 01:53:51 +0800 Subject: [PATCH 09/10] feat(authentication-oauth): Set oAuth redirect URL dynamically (#1608) --- packages/authentication-oauth/src/express.ts | 22 +++++++++---------- packages/authentication-oauth/src/strategy.ts | 6 +++-- .../test/strategy.test.ts | 5 +++++ 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/packages/authentication-oauth/src/express.ts b/packages/authentication-oauth/src/express.ts index 2ef198ee4e..c15b16063b 100644 --- a/packages/authentication-oauth/src/express.ts +++ b/packages/authentication-oauth/src/express.ts @@ -44,6 +44,7 @@ export default (options: OauthSetupSettings) => { if (feathers_token) { debug(`Got feathers_token query parameter to link accounts`, feathers_token); req.session.accessToken = feathers_token; + req.session.query = query; } res.redirect(`${path}/connect/${name}?${qs.stringify(query)}`); @@ -55,12 +56,20 @@ export default (options: OauthSetupSettings) => { authApp.get('/:name/authenticate', async (req, res, next) => { const { name } = req.params as any; - const { accessToken, grant } = req.session; + const { accessToken, grant, query = {} } = req.session; const service = app.defaultAuthentication(authService); const [ strategy ] = service.getStrategies(name) as OAuthStrategy[]; + const params = { + authStrategies: [ name ], + authentication: accessToken ? { + strategy: linkStrategy, + accessToken + } : null, + query + }; const sendResponse = async (data: AuthenticationResult|Error) => { try { - const redirect = await strategy.getRedirect(data); + const redirect = await strategy.getRedirect(data, params); if (redirect !== null) { res.redirect(redirect); @@ -78,15 +87,6 @@ export default (options: OauthSetupSettings) => { try { const payload = config.defaults.transport === 'session' ? grant.response : req.query; - - const params = { - authStrategies: [ name ], - authentication: accessToken ? { - strategy: linkStrategy, - accessToken - } : null - }; - const authentication = { strategy: name, ...payload diff --git a/packages/authentication-oauth/src/strategy.ts b/packages/authentication-oauth/src/strategy.ts index e5ca187db9..d86ec9967a 100644 --- a/packages/authentication-oauth/src/strategy.ts +++ b/packages/authentication-oauth/src/strategy.ts @@ -72,13 +72,15 @@ export class OAuthStrategy extends AuthenticationBaseStrategy { return null; } - async getRedirect (data: AuthenticationResult|Error) { + async getRedirect (data: AuthenticationResult|Error, params?: Params) { + const queryRedirect = (params && params.query && params.query.redirect) || ''; const { redirect } = this.authentication.configuration.oauth; if (!redirect) { return null; } + const redirectUrl = redirect + queryRedirect; const separator = redirect.endsWith('?') ? '' : (redirect.indexOf('#') !== -1 ? '?' : '#'); const authResult: AuthenticationResult = data; @@ -88,7 +90,7 @@ export class OAuthStrategy extends AuthenticationBaseStrategy { error: data.message || 'OAuth Authentication not successful' }; - return redirect + separator + querystring.stringify(query); + return redirectUrl + separator + querystring.stringify(query); } async findEntity (profile: OAuthProfile, params: Params) { diff --git a/packages/authentication-oauth/test/strategy.test.ts b/packages/authentication-oauth/test/strategy.test.ts index 8a52190cf5..a0967719b6 100644 --- a/packages/authentication-oauth/test/strategy.test.ts +++ b/packages/authentication-oauth/test/strategy.test.ts @@ -24,6 +24,11 @@ describe('@feathersjs/authentication-oauth/strategy', () => { let redirect = await strategy.getRedirect({ accessToken: 'testing' }); assert.equal(redirect, '/home#access_token=testing'); + redirect = await strategy.getRedirect({ accessToken: 'testing' }, { + query: { redirect: '/hi-there' } + }); + assert.strictEqual('/home/hi-there#access_token=testing', redirect); + redirect = await strategy.getRedirect(new Error('something went wrong')); assert.equal(redirect, '/home#error=something%20went%20wrong'); From e157e5f1e149a843377cb38f0a72ac191ecc3b45 Mon Sep 17 00:00:00 2001 From: David Luecke Date: Wed, 27 Nov 2019 09:55:13 -0800 Subject: [PATCH 10/10] chore(release): publish v4.4.0 --- lerna.json | 2 +- packages/adapter-commons/CHANGELOG.md | 8 ++++++++ packages/adapter-commons/package.json | 6 +++--- packages/adapter-tests/CHANGELOG.md | 8 ++++++++ packages/adapter-tests/package.json | 6 +++--- packages/authentication-client/CHANGELOG.md | 11 +++++++++++ packages/authentication-client/package.json | 22 ++++++++++----------- packages/authentication-local/CHANGELOG.md | 11 +++++++++++ packages/authentication-local/package.json | 8 ++++---- packages/authentication-oauth/CHANGELOG.md | 11 +++++++++++ packages/authentication-oauth/package.json | 10 +++++----- packages/authentication/CHANGELOG.md | 8 ++++++++ packages/authentication/package.json | 8 ++++---- packages/client/CHANGELOG.md | 8 ++++++++ packages/client/package.json | 22 ++++++++++----------- packages/configuration/CHANGELOG.md | 8 ++++++++ packages/configuration/package.json | 4 ++-- packages/errors/CHANGELOG.md | 8 ++++++++ packages/errors/package.json | 4 ++-- packages/express/CHANGELOG.md | 11 +++++++++++ packages/express/package.json | 12 +++++------ packages/feathers/CHANGELOG.md | 12 +++++++++++ packages/feathers/package.json | 2 +- packages/primus-client/CHANGELOG.md | 8 ++++++++ packages/primus-client/package.json | 10 +++++----- packages/primus/CHANGELOG.md | 8 ++++++++ packages/primus/package.json | 10 +++++----- packages/rest-client/CHANGELOG.md | 12 +++++++++++ packages/rest-client/package.json | 10 +++++----- packages/socketio-client/CHANGELOG.md | 8 ++++++++ packages/socketio-client/package.json | 10 +++++----- packages/socketio/CHANGELOG.md | 11 +++++++++++ packages/socketio/package.json | 10 +++++----- packages/tests/CHANGELOG.md | 8 ++++++++ packages/tests/package.json | 4 ++-- packages/transport-commons/CHANGELOG.md | 11 +++++++++++ packages/transport-commons/package.json | 6 +++--- 37 files changed, 253 insertions(+), 83 deletions(-) diff --git a/lerna.json b/lerna.json index bcc0d3c3ce..7074634d2f 100644 --- a/lerna.json +++ b/lerna.json @@ -3,7 +3,7 @@ "packages": [ "packages/*" ], - "version": "4.3.11", + "version": "4.4.0", "command": { "bootstrap": { "hoist": true diff --git a/packages/adapter-commons/CHANGELOG.md b/packages/adapter-commons/CHANGELOG.md index 8db62d1136..d04415a62a 100644 --- a/packages/adapter-commons/CHANGELOG.md +++ b/packages/adapter-commons/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/adapter-commons + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/adapter-commons diff --git a/packages/adapter-commons/package.json b/packages/adapter-commons/package.json index 097765bfa4..56b60fcafa 100644 --- a/packages/adapter-commons/package.json +++ b/packages/adapter-commons/package.json @@ -1,6 +1,6 @@ { "name": "@feathersjs/adapter-commons", - "version": "4.3.11", + "version": "4.4.0", "description": "Shared database adapter utility functions", "homepage": "https://feathersjs.com", "keywords": [ @@ -42,8 +42,8 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/errors": "^4.3.11", - "@feathersjs/feathers": "^4.3.11" + "@feathersjs/errors": "^4.4.0", + "@feathersjs/feathers": "^4.4.0" }, "devDependencies": { "@types/mocha": "^5.2.7", diff --git a/packages/adapter-tests/CHANGELOG.md b/packages/adapter-tests/CHANGELOG.md index f17827a4bb..3cd854aee2 100644 --- a/packages/adapter-tests/CHANGELOG.md +++ b/packages/adapter-tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/adapter-tests + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/adapter-tests diff --git a/packages/adapter-tests/package.json b/packages/adapter-tests/package.json index 8bc80e37bb..7a406d98dd 100644 --- a/packages/adapter-tests/package.json +++ b/packages/adapter-tests/package.json @@ -1,6 +1,6 @@ { "name": "@feathersjs/adapter-tests", - "version": "4.3.11", + "version": "4.4.0", "description": "Feathers shared database adapter test suite", "homepage": "https://feathersjs.com", "keywords": [ @@ -38,8 +38,8 @@ "access": "public" }, "devDependencies": { - "@feathersjs/errors": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", "feathers-memory": "^4.1.0", "mocha": "^6.2.1" }, diff --git a/packages/authentication-client/CHANGELOG.md b/packages/authentication-client/CHANGELOG.md index e20c8f8ca7..1e67583282 100644 --- a/packages/authentication-client/CHANGELOG.md +++ b/packages/authentication-client/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Bug Fixes + +* **authentication-client:** Reset authentication promise on socket disconnect ([#1696](https://github.com/feathersjs/feathers/issues/1696)) ([3951626](https://github.com/feathersjs/feathers/commit/395162633ff22e95833a3c2900cb9464bb5b056f)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/authentication-client diff --git a/packages/authentication-client/package.json b/packages/authentication-client/package.json index 9ceff6d2f4..a960ab69be 100644 --- a/packages/authentication-client/package.json +++ b/packages/authentication-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-client", "description": "The authentication plugin for feathers-client", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -43,20 +43,20 @@ "access": "public" }, "dependencies": { - "@feathersjs/authentication": "^4.3.11", + "@feathersjs/authentication": "^4.4.0", "@feathersjs/commons": "^4.3.7", - "@feathersjs/errors": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", "debug": "^4.1.1" }, "devDependencies": { - "@feathersjs/authentication-local": "^4.3.11", - "@feathersjs/express": "^4.3.11", - "@feathersjs/primus": "^4.3.11", - "@feathersjs/primus-client": "^4.3.11", - "@feathersjs/rest-client": "^4.3.11", - "@feathersjs/socketio": "^4.3.11", - "@feathersjs/socketio-client": "^4.3.11", + "@feathersjs/authentication-local": "^4.4.0", + "@feathersjs/express": "^4.4.0", + "@feathersjs/primus": "^4.4.0", + "@feathersjs/primus-client": "^4.4.0", + "@feathersjs/rest-client": "^4.4.0", + "@feathersjs/socketio": "^4.4.0", + "@feathersjs/socketio-client": "^4.4.0", "@types/debug": "^4.1.5", "@types/mocha": "^5.2.7", "@types/node": "^12.7.12", diff --git a/packages/authentication-local/CHANGELOG.md b/packages/authentication-local/CHANGELOG.md index 0ae84289c8..cff637815b 100644 --- a/packages/authentication-local/CHANGELOG.md +++ b/packages/authentication-local/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Features + +* **authentication:** Add parseStrategies to allow separate strategies for creating JWTs and parsing headers ([#1708](https://github.com/feathersjs/feathers/issues/1708)) ([5e65629](https://github.com/feathersjs/feathers/commit/5e65629b924724c3e81d7c81df047e123d1c8bd7)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/authentication-local diff --git a/packages/authentication-local/package.json b/packages/authentication-local/package.json index 0d637db83d..f059b628cf 100644 --- a/packages/authentication-local/package.json +++ b/packages/authentication-local/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-local", "description": "Local authentication strategy for @feathers/authentication", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -43,9 +43,9 @@ "access": "public" }, "dependencies": { - "@feathersjs/authentication": "^4.3.11", - "@feathersjs/errors": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/authentication": "^4.4.0", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", "bcryptjs": "^2.4.3", "debug": "^4.1.1", "lodash": "^4.17.15" diff --git a/packages/authentication-oauth/CHANGELOG.md b/packages/authentication-oauth/CHANGELOG.md index 61867a55fa..627042b827 100644 --- a/packages/authentication-oauth/CHANGELOG.md +++ b/packages/authentication-oauth/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Features + +* **authentication-oauth:** Set oAuth redirect URL dynamically ([#1608](https://github.com/feathersjs/feathers/issues/1608)) ([1293e08](https://github.com/feathersjs/feathers/commit/1293e088abbb3d23f4a44680836645a8049ceaae)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) diff --git a/packages/authentication-oauth/package.json b/packages/authentication-oauth/package.json index 2202e98da6..e32d5415cd 100644 --- a/packages/authentication-oauth/package.json +++ b/packages/authentication-oauth/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication-oauth", "description": "oAuth 1 and 2 authentication for Feathers. Powered by Grant.", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -43,10 +43,10 @@ "access": "public" }, "dependencies": { - "@feathersjs/authentication": "^4.3.11", - "@feathersjs/errors": "^4.3.11", - "@feathersjs/express": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/authentication": "^4.4.0", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/express": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", "debug": "^4.1.1", "express-session": "^1.17.0", "grant": "^4.6.3", diff --git a/packages/authentication/CHANGELOG.md b/packages/authentication/CHANGELOG.md index 8fd101377c..993a6d7502 100644 --- a/packages/authentication/CHANGELOG.md +++ b/packages/authentication/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/authentication + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) diff --git a/packages/authentication/package.json b/packages/authentication/package.json index f8225a4120..9b93c24c09 100644 --- a/packages/authentication/package.json +++ b/packages/authentication/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/authentication", "description": "Add Authentication to your FeathersJS app.", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -43,9 +43,9 @@ "access": "public" }, "dependencies": { - "@feathersjs/errors": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/transport-commons": "^4.3.11", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/transport-commons": "^4.4.0", "@types/jsonwebtoken": "8.3.4", "debug": "^4.1.1", "jsonwebtoken": "^8.5.1", diff --git a/packages/client/CHANGELOG.md b/packages/client/CHANGELOG.md index 4031944dfd..974eb838e6 100644 --- a/packages/client/CHANGELOG.md +++ b/packages/client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/client + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/client diff --git a/packages/client/package.json b/packages/client/package.json index b6706ce3ee..7921f53ba4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/client", "description": "A module that consolidates Feathers client modules for REST (jQuery, Request, Superagent) and Websocket (Socket.io, Primus) connections", - "version": "4.3.11", + "version": "4.4.0", "repository": { "type": "git", "url": "https://github.com/feathersjs/feathers.git" @@ -41,16 +41,16 @@ "devDependencies": { "@babel/core": "^7.6.4", "@babel/preset-env": "^7.6.3", - "@feathersjs/authentication-client": "^4.3.11", - "@feathersjs/errors": "^4.3.11", - "@feathersjs/express": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/primus": "^4.3.11", - "@feathersjs/primus-client": "^4.3.11", - "@feathersjs/rest-client": "^4.3.11", - "@feathersjs/socketio": "^4.3.11", - "@feathersjs/socketio-client": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/authentication-client": "^4.4.0", + "@feathersjs/errors": "^4.4.0", + "@feathersjs/express": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/primus": "^4.4.0", + "@feathersjs/primus-client": "^4.4.0", + "@feathersjs/rest-client": "^4.4.0", + "@feathersjs/socketio": "^4.4.0", + "@feathersjs/socketio-client": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "babel-loader": "^8.0.6", "body-parser": "^1.19.0", "feathers-memory": "^4.1.0", diff --git a/packages/configuration/CHANGELOG.md b/packages/configuration/CHANGELOG.md index fb8935cd02..250cbdc466 100644 --- a/packages/configuration/CHANGELOG.md +++ b/packages/configuration/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/configuration + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/configuration diff --git a/packages/configuration/package.json b/packages/configuration/package.json index d38af37048..89f5f1f29c 100644 --- a/packages/configuration/package.json +++ b/packages/configuration/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/configuration", "description": "A small configuration module for your Feathers application.", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -48,7 +48,7 @@ "access": "public" }, "dependencies": { - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", "config": "^3.2.3", "debug": "^4.1.1" }, diff --git a/packages/errors/CHANGELOG.md b/packages/errors/CHANGELOG.md index 4ec35ed05d..81feb210a1 100644 --- a/packages/errors/CHANGELOG.md +++ b/packages/errors/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/errors + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/errors diff --git a/packages/errors/package.json b/packages/errors/package.json index fc6904f649..9fbfa2d9fa 100644 --- a/packages/errors/package.json +++ b/packages/errors/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/errors", "description": "Common error types for Feathers apps", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/index", "types": "index.d.ts", @@ -39,7 +39,7 @@ "debug": "^4.1.1" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", "chai": "^4.2.0", "express": "^4.17.1", "mocha": "^6.2.1", diff --git a/packages/express/CHANGELOG.md b/packages/express/CHANGELOG.md index f83cb0712f..4f3e3d3e5e 100644 --- a/packages/express/CHANGELOG.md +++ b/packages/express/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Features + +* **authentication:** Add parseStrategies to allow separate strategies for creating JWTs and parsing headers ([#1708](https://github.com/feathersjs/feathers/issues/1708)) ([5e65629](https://github.com/feathersjs/feathers/commit/5e65629b924724c3e81d7c81df047e123d1c8bd7)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/express diff --git a/packages/express/package.json b/packages/express/package.json index 10316df9ca..67caf9b2d5 100644 --- a/packages/express/package.json +++ b/packages/express/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/express", "description": "Feathers Express framework bindings and REST provider", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -41,7 +41,7 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/errors": "^4.3.11", + "@feathersjs/errors": "^4.4.0", "@types/express": "^4.17.1", "debug": "^4.1.1", "express": "^4.17.1", @@ -49,10 +49,10 @@ "uberproto": "^2.0.4" }, "devDependencies": { - "@feathersjs/authentication": "^4.3.11", - "@feathersjs/authentication-local": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/authentication": "^4.4.0", + "@feathersjs/authentication-local": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "axios": "^0.19.0", "chai": "^4.2.0", "lodash": "^4.17.15", diff --git a/packages/feathers/CHANGELOG.md b/packages/feathers/CHANGELOG.md index 1171c3a95a..c0fa77059f 100644 --- a/packages/feathers/CHANGELOG.md +++ b/packages/feathers/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Bug Fixes + +* **core:** Improve hook missing parameter message by adding the service name ([#1703](https://github.com/feathersjs/feathers/issues/1703)) ([2331c2a](https://github.com/feathersjs/feathers/commit/2331c2a3dd70d432db7d62a76ed805d359cbbba5)) +* **typescript:** Allow specific service typings for `Hook` and `HookContext` ([#1688](https://github.com/feathersjs/feathers/issues/1688)) ([f5d0ddd](https://github.com/feathersjs/feathers/commit/f5d0ddd9724bf5778355535d2103d59daaad6294)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/feathers diff --git a/packages/feathers/package.json b/packages/feathers/package.json index 3fe6919c0e..a49060f1ed 100644 --- a/packages/feathers/package.json +++ b/packages/feathers/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/feathers", "description": "A framework for real-time applications and REST API with JavaScript and TypeScript", - "version": "4.3.11", + "version": "4.4.0", "homepage": "http://feathersjs.com", "repository": { "type": "git", diff --git a/packages/primus-client/CHANGELOG.md b/packages/primus-client/CHANGELOG.md index bd21eb05b6..0c0dedf155 100644 --- a/packages/primus-client/CHANGELOG.md +++ b/packages/primus-client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/primus-client + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/primus-client diff --git a/packages/primus-client/package.json b/packages/primus-client/package.json index 87d0025896..b79cca66e5 100644 --- a/packages/primus-client/package.json +++ b/packages/primus-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/primus-client", "description": "Client services for Primus and feathers-primus", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -40,13 +40,13 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.11" + "@feathersjs/transport-commons": "^4.4.0" }, "devDependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/primus": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/primus": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "chai": "^4.2.0", "feathers-memory": "^4.1.0", "mocha": "^6.2.1", diff --git a/packages/primus/CHANGELOG.md b/packages/primus/CHANGELOG.md index 7a8f759d4e..c8209be617 100644 --- a/packages/primus/CHANGELOG.md +++ b/packages/primus/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/primus + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/primus diff --git a/packages/primus/package.json b/packages/primus/package.json index c7e6380dd1..6adb0dd47c 100644 --- a/packages/primus/package.json +++ b/packages/primus/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/primus", "description": "The Feathers Primus real-time API provider", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -40,7 +40,7 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.11", + "@feathersjs/transport-commons": "^4.4.0", "debug": "^4.1.1", "primus": "^7.3.4", "primus-emitter": "^3.1.1", @@ -48,9 +48,9 @@ }, "devDependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/express": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/express": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "feathers-memory": "^4.1.0", "lodash": "^4.17.15", "mocha": "^6.2.1", diff --git a/packages/rest-client/CHANGELOG.md b/packages/rest-client/CHANGELOG.md index 38360cfd09..089216f224 100644 --- a/packages/rest-client/CHANGELOG.md +++ b/packages/rest-client/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Bug Fixes + +* **core:** Improve hook missing parameter message by adding the service name ([#1703](https://github.com/feathersjs/feathers/issues/1703)) ([2331c2a](https://github.com/feathersjs/feathers/commit/2331c2a3dd70d432db7d62a76ed805d359cbbba5)) +* **rest-client:** Allow to customize getting the query ([#1594](https://github.com/feathersjs/feathers/issues/1594)) ([5f21272](https://github.com/feathersjs/feathers/commit/5f212729849414c4da6f0d51edd1986feca992ee)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/rest-client diff --git a/packages/rest-client/package.json b/packages/rest-client/package.json index ff0906b87c..0b80b5d9ad 100644 --- a/packages/rest-client/package.json +++ b/packages/rest-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/rest-client", "description": "REST client services for different Ajax libraries", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -41,7 +41,7 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/errors": "^4.3.11", + "@feathersjs/errors": "^4.4.0", "qs": "^6.9.0" }, "devDependencies": { @@ -49,9 +49,9 @@ "@angular/core": "^8.2.10", "@angular/http": "^7.2.15", "@angular/platform-browser": "^8.2.10", - "@feathersjs/express": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/express": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "axios": "^0.19.0", "body-parser": "^1.19.0", "feathers-memory": "^4.1.0", diff --git a/packages/socketio-client/CHANGELOG.md b/packages/socketio-client/CHANGELOG.md index 9284659221..6b3a615af1 100644 --- a/packages/socketio-client/CHANGELOG.md +++ b/packages/socketio-client/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/socketio-client + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/socketio-client diff --git a/packages/socketio-client/package.json b/packages/socketio-client/package.json index 86a5b1eb6e..6cdc234b63 100644 --- a/packages/socketio-client/package.json +++ b/packages/socketio-client/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/socketio-client", "description": "The client for Socket.io through feathers-socketio", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/index.js", "types": "index.d.ts", @@ -40,14 +40,14 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.11", + "@feathersjs/transport-commons": "^4.4.0", "@types/socket.io-client": "^1.4.32" }, "devDependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/socketio": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/socketio": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "chai": "^4.2.0", "feathers-memory": "^4.1.0", "mocha": "^6.2.1", diff --git a/packages/socketio/CHANGELOG.md b/packages/socketio/CHANGELOG.md index e87bcc24fd..60b9ee1432 100644 --- a/packages/socketio/CHANGELOG.md +++ b/packages/socketio/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Features + +* **authentication:** Add parseStrategies to allow separate strategies for creating JWTs and parsing headers ([#1708](https://github.com/feathersjs/feathers/issues/1708)) ([5e65629](https://github.com/feathersjs/feathers/commit/5e65629b924724c3e81d7c81df047e123d1c8bd7)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/socketio diff --git a/packages/socketio/package.json b/packages/socketio/package.json index 411ce7bf64..8b0f9381cd 100644 --- a/packages/socketio/package.json +++ b/packages/socketio/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/socketio", "description": "The Feathers Socket.io real-time API provider", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "index.d.ts", @@ -40,7 +40,7 @@ "access": "public" }, "dependencies": { - "@feathersjs/transport-commons": "^4.3.11", + "@feathersjs/transport-commons": "^4.4.0", "@types/socket.io": "^2.1.4", "debug": "^4.1.1", "socket.io": "^2.3.0", @@ -48,9 +48,9 @@ }, "devDependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/express": "^4.3.11", - "@feathersjs/feathers": "^4.3.11", - "@feathersjs/tests": "^4.3.11", + "@feathersjs/express": "^4.4.0", + "@feathersjs/feathers": "^4.4.0", + "@feathersjs/tests": "^4.4.0", "feathers-memory": "^4.1.0", "lodash": "^4.17.15", "mocha": "^6.2.1", diff --git a/packages/tests/CHANGELOG.md b/packages/tests/CHANGELOG.md index 832d464fa3..74805b6a58 100644 --- a/packages/tests/CHANGELOG.md +++ b/packages/tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + +**Note:** Version bump only for package @feathersjs/tests + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/tests diff --git a/packages/tests/package.json b/packages/tests/package.json index 79f4f4f1af..af1818a3b2 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -2,7 +2,7 @@ "name": "@feathersjs/tests", "private": true, "description": "Feathers core module common tests", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "keywords": [ @@ -46,7 +46,7 @@ "lodash": "^4.17.15" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", "@types/axios": "^0.14.0", "@types/debug": "^4.1.5", "@types/lodash": "^4.14.144", diff --git a/packages/transport-commons/CHANGELOG.md b/packages/transport-commons/CHANGELOG.md index c04ea69f99..85ced3fb6a 100644 --- a/packages/transport-commons/CHANGELOG.md +++ b/packages/transport-commons/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [4.4.0](https://github.com/feathersjs/feathers/compare/v4.3.11...v4.4.0) (2019-11-27) + + +### Bug Fixes + +* **transport-commons:** Allow to properly chain SocketIo client.off ([#1706](https://github.com/feathersjs/feathers/issues/1706)) ([a4aecbc](https://github.com/feathersjs/feathers/commit/a4aecbcd3578c1cf4ecffb3a58fb6d26e15ee513)) + + + + + ## [4.3.11](https://github.com/feathersjs/feathers/compare/v4.3.10...v4.3.11) (2019-11-11) **Note:** Version bump only for package @feathersjs/transport-commons diff --git a/packages/transport-commons/package.json b/packages/transport-commons/package.json index baeeccb1fe..c2377a6b6a 100644 --- a/packages/transport-commons/package.json +++ b/packages/transport-commons/package.json @@ -1,7 +1,7 @@ { "name": "@feathersjs/transport-commons", "description": "Shared functionality for websocket providers", - "version": "4.3.11", + "version": "4.4.0", "homepage": "https://feathersjs.com", "main": "lib/", "types": "lib/", @@ -44,13 +44,13 @@ }, "dependencies": { "@feathersjs/commons": "^4.3.7", - "@feathersjs/errors": "^4.3.11", + "@feathersjs/errors": "^4.4.0", "debug": "^4.1.1", "lodash": "^4.17.15", "radix-router": "^3.0.1" }, "devDependencies": { - "@feathersjs/feathers": "^4.3.11", + "@feathersjs/feathers": "^4.4.0", "@types/debug": "^4.1.5", "@types/mocha": "^5.2.7", "@types/node": "^12.7.12",