fix(typescript): finally should be optional (#1350)

bitflower · daffl · commit f439a9eb50ed · 2019-05-14T20:32:35.000-07:00
diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts
@@ -133,7 +133,7 @@ declare namespace createApplication {
         before: Partial<HookMap> | Hook | Hook[];
         after: Partial<HookMap> | Hook | Hook[];
         error: Partial<HookMap> | Hook | Hook[];
-        finally: Partial<HookMap> | Hook | Hook[];
+        finally?: Partial<HookMap> | Hook | Hook[];
     }
 
     // todo: figure out what to do: These methods don't actually need to be

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ declare namespace createApplication {`
`133`	`133`	`before: Partial<HookMap> \| Hook \| Hook[];`
`134`	`134`	`after: Partial<HookMap> \| Hook \| Hook[];`
`135`	`135`	`error: Partial<HookMap> \| Hook \| Hook[];`
`136`		`- finally: Partial<HookMap> \| Hook \| Hook[];`
	`136`	`+ finally?: Partial<HookMap> \| Hook \| Hook[];`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`// todo: figure out what to do: These methods don't actually need to be`