fix: Do not inherit app object from Object prototype (#1153)

daffl · web-flow · commit ed8c2e475c2f · 2019-01-02T14:26:05.000-08:00
diff --git a/.gitignore b/.gitignore
@@ -34,3 +34,4 @@ node_modules
 
 # Distributables
 dist/
+.nyc_output/
diff --git a/packages/feathers/lib/index.js b/packages/feathers/lib/index.js
@@ -3,9 +3,12 @@ const Proto = require('uberproto');
 const Application = require('./application');
 const version = require('./version');
 const { ACTIVATE_HOOKS, activateHooks } = require('./hooks');
+// A base object Prototype that does not inherit from a
+// potentially polluted Object prototype
+const baseObject = Object.create(null);
 
 function createApplication () {
-  const app = {};
+  const app = Object.create(baseObject);
 
   // Mix in the base application
   Proto.mixin(Application, app);
