Fixed #36357 -- Skipped unique_together in inspectdb output for composite primary keys.

bmispelon · nessita · nessita · commit 66f9eb0ff1e7 · 2025-04-30T11:55:25.000-03:00
Thanks to Baptiste Mispelon for the report and quick fix, and to Simon
Charette and Jacob Walls for the reviews.

Co-authored-by: Natalia &lt;124304+nessita@users.noreply.github.com&gt;
diff --git a/django/core/management/commands/inspectdb.py b/django/core/management/commands/inspectdb.py
@@ -391,7 +391,7 @@ def get_meta(
                 columns = [
                     x for x in columns if x is not None and x in column_to_field_name
                 ]
-                if len(columns) > 1:
+                if len(columns) > 1 and not params["primary_key"]:
                     unique_together.append(
                         str(tuple(column_to_field_name[c] for c in columns))
                     )
diff --git a/docs/releases/5.2.1.txt b/docs/releases/5.2.1.txt
@@ -59,3 +59,7 @@ Bugfixes
 * Fixed a bug in composite primary key introspection that caused
   ``IntegerField`` to be wrongly identified as ``AutoField`` on SQLite
   (:ticket:`36358`).
+
+* Fixed a bug in Django 5.2 that caused a redundant ``unique_together``
+  constraint to be generated for composite primary keys when using
+  :djadmin:`inspectdb` (:ticket:`36357`).
diff --git a/tests/inspectdb/tests.py b/tests/inspectdb/tests.py
@@ -637,3 +637,8 @@ def test_composite_primary_key(self):
         )
         self.assertIn(f"column_1 = models.{field_type}()", output)
         self.assertIn(f"column_2 = models.{field_type}()", output)
+
+    def test_composite_primary_key_not_unique_together(self):
+        out = StringIO()
+        call_command("inspectdb", "inspectdb_compositeprimarykeymodel", stdout=out)
+        self.assertNotIn("unique_together", out.getvalue())

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ def get_meta(`
`391`	`391`	`columns = [`
`392`	`392`	`x for x in columns if x is not None and x in column_to_field_name`
`393`	`393`	`]`
`394`		`- if len(columns) > 1:`
	`394`	`+ if len(columns) > 1 and not params["primary_key"]:`
`395`	`395`	`unique_together.append(`
`396`	`396`	`str(tuple(column_to_field_name[c] for c in columns))`
`397`	`397`	`)`
Original file line number	Diff line number	Diff line change
`@@ -637,3 +637,8 @@ def test_composite_primary_key(self):`
`637`	`637`	`)`
`638`	`638`	`self.assertIn(f"column_1 = models.{field_type}()", output)`
`639`	`639`	`self.assertIn(f"column_2 = models.{field_type}()", output)`
	`640`	`+`
	`641`	`+ def test_composite_primary_key_not_unique_together(self):`
	`642`	`+ out = StringIO()`
	`643`	`+ call_command("inspectdb", "inspectdb_compositeprimarykeymodel", stdout=out)`
	`644`	`+ self.assertNotIn("unique_together", out.getvalue())`