8000 Comparing main...fix_stack_overflow · fe-lang/sonatina · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fe-lang/sonatina
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: fe-lang/sonatina
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix_stack_overflow
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 1, 2026

  1. Fix infinite recursion in GVN value-phi computation

    The ValuePhiFinder can enter an infinite recursion cycle through
    lookup_value_phi_arg → compute_value_phi → compute_value_phi_for_binary
    → lookup_value_phi_arg when the same GVN instruction query is
    encountered again during recursive value-phi resolution.
    
    Add a `visited_queries` set to ValuePhiFinder that tracks which GVN
    instructions are currently being resolved on the call stack. If a
    query is seen a second time, bail out with None to break the cycle.
    The entry is removed after the recursive call returns (backtracking)
    so that the same query reached through a different non-cyclic branch
    is not incorrectly suppressed.
    cburgdorf committed Mar 1, 2026
    Configuration menu
    Copy the full SHA
    7159bd0 View commit details
    Browse the repository at this point in the history
Loading
0