8000 disable vector index on ARM for now, faiss is known to be crashy now.… · fceller/arangodb@a4f8f3b · GitHub
[go: up one dir, main page]
Skip to content

Commit a4f8f3b

Browse files
dothebartdothebart
authored
disable vector index on ARM for now, faiss is known to be crashy now. (arangodb#21718)
* disable vector index on ARM for now, faiss is known to be crashy now. * lint * lint * disable on ARM * disable on ARM
1 parent aafe0d1 commit a4f8f3b

File tree

6 files changed

+38
-18
lines changed

6 files changed

+38
-18
lines changed

‎js/client/modules/@arangodb/testutils/client-tools.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,16 @@ function rtaMakedata(options, instanceManager, writeReadClean, msg, logFile, mor
545545
if (addArgs !== undefined) {
546546
args = Object.assign(args, addArgs);
547547
}
548+
// TODO: vector index broken on circleci-ARM
549+
if (versionHas("arm")) {
550+
let skipOffset = moreargv.findIndex(i => {return i === '--skip';});
551+
if (skipOffset >= 0) {
552+
moreargv[skipOffset + 1] += ',107';
553+
} else {
554+
moreargv = ['--skip', '107_'];
555+
}
556+
}
557+
548558
let argv = toArgv(args);
549559
argv = argv.concat(['--', options.makedataDB],
550560
moreargv, [

‎tests/js/client/aql/vector/aql-vector-agency-wrong-definition-cluster.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ let {
4646
} = require('@arangodb/test-helper');
4747

4848
let IM = global.instanceManager;
49+
const { versionHas } = require("@arangodb/test-helper");
4950

5051
////////////////////////////////////////////////////////////////////////////////
5152
/// @brief test suite
@@ -262,7 +263,8 @@ function VectorIndexInvalidDefinitionInAgencyTest() {
262263
};
263264
}
264265

265-
jsunity.run(VectorIndexCorrectDefinitionInAgencyTest);
266-
jsunity.run(VectorIndexInvalidDefinitionInAgencyTest);
267-
266+
if (!versionHas("arm")) {
267+
jsunity.run(VectorIndexCorrectDefinitionInAgencyTest);
268+
jsunity.run(VectorIndexInvalidDefinitionInAgencyTest);
269+
}
268270
return jsunity.done();

‎tests/js/client/aql/vector/aql-vector-create-and-remove.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ const {
3535
randomNumberGeneratorFloat,
3636
} = require("@arangodb/testutils/seededRandom");
3737

38+
const { versionHas } = require("@arangodb/test-helper");
39+
3840
const dbName = "vectorDB";
3941
const collName = "coll";
4042
const indexName = "vectorIndex";
@@ -319,7 +321,8 @@ function VectorIndexTestCreationWithVectors() {
319321
}
320322

321323

322-
jsunity.run(VectorIndexCreateAndRemoveTestSuite);
323-
jsunity.run(VectorIndexTestCreationWithVectors);
324-
324+
if (!versionHas("arm")) {
325+
jsunity.run(VectorIndexCreateAndRemoveTestSuite);
326+
jsunity.run(VectorIndexTestCreationWithVectors);
327+
}
325328
return jsunity.done();

‎tests/js/client/aql/vector/aql-vector-full-count.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const {
3737
randomNumberGeneratorFloat,
3838
} = require("@arangodb/testutils/seededRandom");
3939

40+
const { versionHas } = require("@arangodb/test-helper");
4041
const isCluster = require("internal").isCluster();
4142
const dbName = "vectorDB";
4243
const collName = "vectorColl";
@@ -416,8 +417,9 @@ function VectorIndexFullCountCollectionWithSmallAmountOfDocs() {
416417
};
417418
}
418419

419-
jsunity.run(VectorIndexFullCountTestSuite);
420-
jsunity.run(VectorIndexFullCountWithNotEnoughNListsTestSuite);
421-
jsunity.run(VectorIndexFullCountCollectionWithSmallAmountOfDocs);
422-
423-
return jsunity.done();
420+
if (!versionHas("arm")) {
421+
jsunity.run(VectorIndexFullCountTestSuite);
422+
jsunity.run(VectorIndexFullCountWithNotEnoughNListsTestSuite);
423+
jsunity.run(VectorIndexFullCountCollectionWithSmallAmountOfDocs);
424+
}
425+
return jsunity.done();

‎tests/js/client/aql/ve 10000 ctor/aql-vector-nprobe.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const {
3737
randomNumberGeneratorFloat,
3838
} = require("@arangodb/testutils/seededRandom");
3939

40+
const { versionHas } = require("@arangodb/test-helper");
4041
const isCluster = require("internal").isCluster();
4142
const dbName = "vectorDB";
4243
const collName = "vectorColl";
@@ -162,6 +163,7 @@ function VectorIndexL2NprobeTestSuite() {
162163
};
163164
}
164165

165-
jsunity.run(VectorIndexL2NprobeTestSuite);
166-
166+
if (!versionHas("arm")) {
167+
jsunity.run(VectorIndexL2NprobeTestSuite);
168+
}
167169
return jsunity.done();

‎tests/js/client/aql/vector/aql-vector.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const db = internal.db;
3636
const {
3737
randomNumberGeneratorFloat,
3838
} = require("@arangodb/testutils/seededRandom");
39-
39+
const { versionHas } = require("@arangodb/test-helper");
4040
const isCluster = require("internal").isCluster();
4141
const dbName = "vectorDb";
4242
const collName = "vectorColl";
@@ -884,9 +884,10 @@ function MultipleVectorIndexesOnField() {
884884
};
885885
}
886886

887-
jsunity.run(VectorIndexL2TestSuite);
888-
jsunity.run(VectorIndexCosineTestSuite);
889-
jsunity.run(MultipleVectorIndexesOnField);
890-
887+
if (!versionHas("arm")) {
888+
jsunity.run(VectorIndexL2TestSuite);
889+
jsunity.run(VectorIndexCosineTestSuite);
890+
jsunity.run(MultipleVectorIndexesOnField);
891+
}
891892
return jsunity.done();
892893

0 commit comments

Comments
 (0)
0