update contrib guide for git-lfs#391
Merged
kushalkolar merged 1 commit intofastplotlib:mainfrom Dec 5, 2023
Merged
Conversation
kushalkolar
requested changes
Dec 4, 2023
Member
|
Thanks for this! :D Yes it should be safe to add |
Member
|
Nevermind you're right sorry! We don't have an empty diffs dir in main (@clewis7 wrote the entire test suite so I'm sometimes unfamiliar with the details here) |
Contributor
Author
|
Right, so the main question (for you all), is whether you ever intend to check stuff into diffs, or if it's always the byproduct product of a test. If the latter, just add it to gitignore, and then developers don't need to pay any special attention to it. |
Member
|
Yup it's indeed the latter! |
Member
|
Bypassing CI for this since no source files are touched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #388
@kushalkolar, how's this read?
also, do you ever commit stuff in
diffs/? or is it worth adding it to git ignore?