8000 chore: removed simple-get from async-delay-request tests (#6211) · fastify/fastify@1b46ddf · GitHub
[go: up one dir, main page]

Skip to content

Commit 1b46ddf

Browse files
chore: removed simple-get from async-delay-request tests (#6211)
Co-authored-by: Jean <110341611+jean-michelet@users.noreply.github.com>
1 parent 3bf4f10 commit 1b46ddf

File tree

1 file changed

+7
-16
lines changed

1 file changed

+7
-16
lines changed

test/diagnostics-channel/async-delay-request.test.js

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22

33
const diagnostics = require('node:diagnostics_channel')
44
const { test } = require('node:test')
5-
const sget = require('simple-get').concat
65
const Fastify = require('../..')
7-
const { getServerUrl } = require('../helper')
86
const Request = require('../../lib/request')
97
const Reply = require('../../lib/reply')
108

11-
test('diagnostics channel async events fire in expected order', (t, done) => {
9+
test('diagnostics channel async events fire in expected order', async t => {
1210
t.plan(19)
1311
let callOrder = 0
1412
let firstEncounteredMessage
@@ -56,19 +54,12 @@ test('diagnostics channel async events fire in expected order', (t, done) => {
5654
}
5755
})
5856

59-
fastify.listen({ port: 0 }, function (err) {
60-
if (err) t.assert.ifError(err)
57+
t.after(() => { fastify.close() })
6158

62-
t.after(() => { fastify.close() })
59+
const fastifyServer = await fastify.listen({ port: 0 })
6360

64-
sget({
65-
method: 'GET',
66-
url: getServerUrl(fastify) + '/'
67-
}, (err, response, body) => {
68-
t.assert.ifError(err)
69-
t.assert.strictEqual(response.statusCode, 200)
70-
t.assert.deepStrictEqual(JSON.parse(body), { hello: 'world' })
71-
done()
72-
})
73-
})
61+
const result = await fetch(fastifyServer + '/')
62+
t.assert.ok(result.ok)
63+
t.assert.strictEqual(result.status, 200)
64+
t.assert.deepStrictEqual(await result.json(), { hello: 'world' })
7465
})

0 commit comments

Comments
 (0)
0