-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
🌐 Add Korean translation for docs/tutorial/request-files.md
#3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be best if you used less "띄어쓰기".
e.g.
something입니다. ->something입니다.something: 설명 ->something: 설명
Let me know what you think.
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
|
@hard-coders Thank you for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit appreciate of your works and great honor to check it.
Feel free to check my reviews 🚀
Also, please update (fetch) the file to the latest version.
|
|
||
| 선언한대로, `bytes` 의 `list` 또는 `UploadFile` 들을 전송받을 것입니다. | ||
|
|
||
| !!! note "참고" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this note section is deprecated in the docs. Please update (fetch) the file to the latest version.
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #3743 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 409 409
Lines 10264 10264
=========================================
Hits 10264 10264 Continue to review full report at Codecov.
|
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
|
📝 Docs preview for commit 78dbcf2 at: https://61a303bef233071a028c3fa1--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
Amazing, thanks @NinaHwang! 🙇 🍪 And thanks for the reviews @hard-coders and @0417taehyun! 🚀 |
This PR translates tutorial/request-files.md in Korean.
related: #2017