8000 🌐 Add Japanese translation for Features by tokusumi · Pull Request #1625 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

🌐 Add Japanese translation for Features #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 15 commits into from
Oct 16, 2020
Merged

🌐 Add Japanese translation for Features #1625

tiangolo merged 15 commits into from
Oct 16, 2020

Conversation

@tokusumi
Copy link
Contributor
@tokusumi tokusumi commented Jun 25, 2020 •
edited
Loading

This PR translates the features.md to Japanese.
Please review features.md.

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@codecov
Copy link
codecov bot commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #1625 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdd371...b333f1a. Read the comment docs.

@tokusumi tokusumi mentioned this pull request Jun 25, 2020
Closed
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Jun 27, 2020
SwftAlpc
SwftAlpc suggested changes Aug 15, 2020
View reviewed changes
Copy link
Contributor
@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the excellent translation.
There are a few things that I noticed and I would like to suggest some corrections.

docs/ja/docs/features.md Outdated

FastAPIには非常に使いやすく、非常に強力な<abbr title='also known as "components", "resources", "services", "providers"'><strong>依存性の注入</strong></abbr>システムを備えています。

* 階層または **依存関係の"グラフ"** を作成することで、依存関係でさえも依存関係を持つことができます。
Copy link
Contributor
@SwftAlpc SwftAlpc Aug 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

依存関係でさえも依存関係を持つことができ、階層または 依存関係の"グラフ” を作成することができます。

@tokusumi
Copy link
Contributor Author
tokusumi commented Aug 15, 2020

@SwftAlpc Thank you for your good suggestions. I improved translation. Please re-review and approve this PR if you want.

SwftAlpc
SwftAlpc approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor
@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response.
LGTM!

@github-actions
Copy link
Contributor
github-actions bot commented Aug 15, 2020

📝 Docs preview for commit dfbf133 at: https://5f37c2ae1c8489711bfacd42--fastapi.netlify.app

@github-actions
Copy link
Contributor
github-actions bot commented Aug 15, 2020

📝 Docs preview for commit 6013a0b at: https://5f37d177fb8f784b80f53a47--fastapi.netlify.app

@tokusumi tokusumi marked this pull request as ready for review August 16, 2020 22:58
@ryuckel
Copy link
Contributor
ryuckel commented Aug 21, 2020

LGTM!

@github-actions
Copy link
Contributor
github-actions bot commented Aug 29, 2020

📝 Docs preview for commit b333f1a at: https://5f4a62593025493347748637--fastapi.netlify.app

@tokusumi
Copy link
Contributor Author
tokusumi commented Sep 26, 2020

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolo tiangolo changed the title Add Japanese translation for features.md 🌐 Add Japanese translation for Features Oct 16, 2020
@tiangolo tiangolo merged commit 74f13e5 into fastapi:master Oct 16, 2020
@tiangolo
Copy link
Member
tiangolo commented Oct 16, 2020

Awesome! Thank you @tokusumi ! 🙇 🍰

And thank you @ryuckel and @SwftAlpc for the reviews 👏 ☕

Indeed, the GitHub action to manage the labels wasn't working correctly, so I just created a new one that is finally working 😄 🤖

@tokusumi tokusumi deleted the feature/japanese-features-md branch October 17, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ryuckel ryuckel ryuckel approved these changes

@SwftAlpc SwftAlpc SwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @ryuckel @tiangolo @SwftAlpc
0