Autocomplete: Handle detached elements for appendTo after create.

scottgonzalez · scottgonzalez · commit da17a232ca55 · 2012-12-07T11:58:58.000-05:00
diff --git a/tests/unit/autocomplete/autocomplete_options.js b/tests/unit/autocomplete/autocomplete_options.js
@@ -5,7 +5,7 @@ module( "autocomplete: options" );
 var data = [ "c++", "java", "php", "coldfusion", "javascript", "asp", "ruby", "python", "c", "scala", "groovy", "haskell", "perl" ];
 
 test( "appendTo", function() {
-	expect( 7 );
+	expect( 8 );
 	var detached = $( "<div>" ),
 		element = $( "#autocomplete" ).autocomplete();
 	equal( element.autocomplete( "widget" ).parent()[0], document.body, "defaults to body" );
@@ -39,6 +39,10 @@ test( "appendTo", function() {
 	});
 	equal( element.autocomplete( "widget" ).parent()[0], detached[0], "detached DOM element" );
 	element.autocomplete( "destroy" );
+
+	element.autocomplete().autocomplete( "option", "appendTo", detached );
+	equal( element.autocomplete( "widget" ).parent()[0], detached[0], "detached DOM element via option()" );
+	element.autocomplete( "destroy" );
 });
 
 function autoFocusTest( afValue, focusedLength ) {
diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js
@@ -314,7 +314,7 @@ $.widget( "ui.autocomplete", {
 			this._initSource();
 		}
 		if ( key === "appendTo" ) {
-			this.menu.element.appendTo( this.document.find( value || "body" )[0] );
+			this.menu.element.appendTo( this._appendTo() );
 		}
 		if ( key === "disabled" && value && this.xhr ) {
 			this.xhr.abort();

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ $.widget( "ui.autocomplete", {`
`314`	`314`	`this._initSource();`
`315`	`315`	`}`
`316`	`316`	`if ( key === "appendTo" ) {`
`317`		`- this.menu.element.appendTo( this.document.find( value \|\| "body" )[0] );`
	`317`	`+ this.menu.element.appendTo( this._appendTo() );`
`318`	`318`	`}`
`319`	`319`	`if ( key === "disabled" && value && this.xhr ) {`
`320`	`320`	`this.xhr.abort();`