minor symfony#43355 [Messenger] Add worker metadata inside logs (noniagriconomie)

fabpot · fabpot · commit 626d9aab9305 · 2021-10-07T17:58:05.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Add worker metadata inside logs | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | . | Deprecations? | no | Tickets | Improve symfony#42723 | License | MIT | Doc PR | . Small PR related to one of my comment symfony#42723 (comment) on the ticket PR: having this contextual info is valuable imho cc `@ruudk` `@okwinza` `@fabpot` Commits ------- 649cb10 [Messenger] Add worker metadata inside logs
diff --git a/src/Symfony/Component/Messenger/EventListener/StopWorkerOnSigtermSignalListener.php b/src/Symfony/Component/Messenger/EventListener/StopWorkerOnSigtermSignalListener.php
@@ -31,7 +31,7 @@ public function onWorkerStarted(WorkerStartedEvent $event): void
     {
         pcntl_signal(\SIGTERM, function () use ($event) {
             if (null !== $this->logger) {
-                $this->logger->info('Received SIGTERM signal.');
+                $this->logger->info('Received SIGTERM signal.', ['transport_names' => $event->getWorker()->getMetadata()->getTransportNames()]);
             }
 
             $event->getWorker()->stop();
diff --git a/src/Symfony/Component/Messenger/Worker.php b/src/Symfony/Component/Messenger/Worker.php
@@ -177,7 +177,7 @@ private function handleMessage(Envelope $envelope, ReceiverInterface $receiver,
     public function stop(): void
     {
         if (null !== $this->logger) {
-            $this->logger->info('Stopping worker.');
+            $this->logger->info('Stopping worker.', ['transport_names' => $this->metadata->getTransportNames()]);
         }
 
         $this->shouldStop = true;

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function onWorkerStarted(WorkerStartedEvent $event): void`
`31`	`31`	`{`
`32`	`32`	`pcntl_signal(\SIGTERM, function () use ($event) {`
`33`	`33`	`if (null !== $this->logger) {`
`34`		`- $this->logger->info('Received SIGTERM signal.');`
	`34`	`+ $this->logger->info('Received SIGTERM signal.', ['transport_names' => $event->getWorker()->getMetadata()->getTransportNames()]);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`$event->getWorker()->stop();`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ private function handleMessage(Envelope $envelope, ReceiverInterface $receiver,`
`177`	`177`	`public function stop(): void`
`178`	`178`	`{`
`179`	`179`	`if (null !== $this->logger) {`
`180`		`- $this->logger->info('Stopping worker.');`
	`180`	`+ $this->logger->info('Stopping worker.', ['transport_names' => $this->metadata->getTransportNames()]);`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`$this->shouldStop = true;`