minor symfony#27878 improve deprecation messages (xabbuh)

fabpot · fabpot · commit 3f663fdfbb58 · 2018-07-12T08:18:35.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- improve deprecation messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1657b82 improve deprecation messages
diff --git a/src/Symfony/Bundle/SecurityBundle/Security/FirewallContext.php b/src/Symfony/Bundle/SecurityBundle/Security/FirewallContext.php
@@ -36,7 +36,7 @@ public function __construct(iterable $listeners, ExceptionListener $exceptionLis
         $this->exceptionListener = $exceptionListener;
         if ($logoutListener instanceof FirewallConfig) {
             $this->config = $logoutListener;
-            @trigger_error(sprintf('Passing an instance of %s as 3rd argument to %s() is deprecated since Symfony 4.2. Pass a %s instance instead.', FirewallConfig::class, __METHOD__, LogoutListener::class), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Passing an instance of %s as the 3rd argument to "%s()" is deprecated since Symfony 4.2. Pass a %s instance instead.', FirewallConfig::class, __METHOD__, LogoutListener::class), E_USER_DEPRECATED);
         } elseif (null === $logoutListener || $logoutListener instanceof LogoutListener) {
             $this->logoutListener = $logoutListener;
             $this->config = $config;
diff --git a/src/Symfony/Component/Cache/CacheItem.php b/src/Symfony/Component/Cache/CacheItem.php
@@ -162,7 +162,7 @@ public function tag($tags)
      */
     public function getPreviousTags()
     {
-        @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2, use the "getMetadata()" method instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the "getMetadata()" method instead.', __METHOD__), E_USER_DEPRECATED);
 
         return $this->metadata[self::METADATA_TAGS] ?? array();
     }
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AnalyzeServiceReferencesPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AnalyzeServiceReferencesPass.php
@@ -50,7 +50,7 @@ public function __construct(bool $onlyConstructorArguments = false)
      */
     public function setRepeatedPass(RepeatedPass $repeatedPass)
     {
-        @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
     }
 
     /**
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -42,7 +42,7 @@ public function __construct(AnalyzeServiceReferencesPass $analyzingPass = null)
      */
     public function setRepeatedPass(RepeatedPass $repeatedPass)
     {
-        @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
         $this->repeatedPass = $repeatedPass;
     }
 
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php
@@ -29,7 +29,7 @@ class RemoveUnusedDefinitionsPass extends AbstractRecursivePass implements Repea
      */
     public function setRepeatedPass(RepeatedPass $repeatedPass)
     {
-        @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public function tag($tags)`
`162`	`162`	`*/`
`163`	`163`	`public function getPreviousTags()`
`164`	`164`	`{`
`165`		`- @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2, use the "getMetadata()" method instead.', __METHOD__), E_USER_DEPRECATED);`
	`165`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the "getMetadata()" method instead.', __METHOD__), E_USER_DEPRECATED);`
`166`	`166`
`167`	`167`	`return $this->metadata[self::METADATA_TAGS] ?? array();`
`168`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function __construct(bool $onlyConstructorArguments = false)`
`50`	`50`	`*/`
`51`	`51`	`public function setRepeatedPass(RepeatedPass $repeatedPass)`
`52`	`52`	`{`
`53`		`- @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
	`53`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct(AnalyzeServiceReferencesPass $analyzingPass = null)`
`42`	`42`	`*/`
`43`	`43`	`public function setRepeatedPass(RepeatedPass $r A977 epeatedPass)`
`44`	`44`	`{`
`45`		`- @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
	`45`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
`46`	`46`	`$this->repeatedPass = $repeatedPass;`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class RemoveUnusedDefinitionsPass extends AbstractRecursivePass implements Repea`
`29`	`29`	`*/`
`30`	`30`	`public function setRepeatedPass(RepeatedPass $repeatedPass)`
`31`	`31`	`{`
`32`		`- @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
	`32`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`/**`