8000 minor #27858 [Console] changed warning verbosity; fixes typo (adrian-… · fancyweb/symfony@02daeb2 · GitHub
[go: up one dir, main page]

Skip to content

Commit 02daeb2

Browse files
author
Robin Chalas
committed
minor symfony#27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)
This PR was merged into the 4.2-dev branch. Discussion ---------- [Console] changed warning verbosity; fixes typo | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes* | Fixed tickets | n/a | License | MIT | Doc PR | n/a * Tests pass, but I do not have an installation of MacOS to run tests on. Tests should be unaffected (the test is simply [skipped on MacOS]( 8000 https://github.com/symfony/console/blob/master/Tests/Command/CommandTest.php#L345)). When a Console Command fails to change the process title on MacOS, a warning is issued to output. This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing. This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage. I've also fixed a typo in the message ("get" vs. "set"). Commits ------- 86c771a changed warning verbosity; fixes typo
2 parents 7135aa4 + 86c771a commit 02daeb2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/Symfony/Component/Console/Command/Command.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,10 @@ public function run(InputInterface $input, OutputInterface $output)
220220
if (function_exists('cli_set_process_title')) {
221221
if (!@cli_set_process_title($this->processTitle)) {
222222
if ('Darwin' === PHP_OS) {
223-
$output->writeln('<comment>Running "cli_get_process_title" as an unprivileged user is not supported on MacOS.</comment>');
223+
$output->writeln(
224+
'<comment>Running "cli_set_process_title" as an unprivileged user is not supported on MacOS.</comment>',
225+
OutputInterface::VERBOSITY_VERY_VERBOSE
226+
);
224227
} else {
225228
cli_set_process_title($this->processTitle);
226229
}

0 commit comments

Comments
 (0)
0