8000 [build-tools] Handle ASC server-side unexpected errors (500) by sjchmiela · Pull Request #3467 · expo/eas-cli · GitHub
[go: up one dir, main page]
Skip to content

[build-tools] Handle ASC server-side unexpected errors (500)#3467

Draft
sjchmiela wants to merge 1 commit intomainfrom
stanley/asc-500-unexpected-error
Draft

[build-tools] Handle ASC server-side unexpected errors (500)#3467
sjchmiela wants to merge 1 commit intomainfrom
stanley/asc-500-unexpected-error

Conversation

@sjchmiela
Copy link
Contributor
@sjchmiela sjchmiela commented Mar 5, 2026 •
edited
Loading

Why

UNKNOWN submit failures include App Store Connect 500 UNEXPECTED_ERROR responses while polling build upload status.

This case is typically transient/server-side and should provide explicit retry guidance instead of generic unknown.

How

  • add recognition helper for AscApiRequestError with 500 + UNEXPECTED_ERROR
  • handle this in build-upload status polling in upload_to_asc
  • throw EAS_UPLOAD_TO_ASC_SERVER_ERROR with retry-oriented user-facing guidance
  • add unit tests for isAscUnexpectedServerError

Examples

Test Plan

  • yarn --cwd packages/build-tools jest-unit src/steps/functions/__tests__/uploadToAsc.test.ts
  • yarn --cwd packages/build-tools typecheck
  • yarn fmt

@github-actions
Copy link
github-actions bot commented Mar 5, 2026

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@codecov
Copy link
codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.15%. Comparing base (146656c) to head (4aa9bf7).

Files with missing lines Patch % Lines
...ges/build-tools/src/steps/functions/uploadToAsc.ts 50.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3467      +/-   ##
==========================================
- Coverage   53.15%   53.15%   -0.00%     
==========================================
  Files         811      811              
  Lines       34236    34246      +10     
  Branches     7124     7127       +3     
==========================================
+ Hits        18195    18200       +5     
- Misses      15960    15965       +5     
  Partials       81       81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sjchmiela
0