From 99f96d620a3f07ea46b189448ea2b22337bfde50 Mon Sep 17 00:00:00 2001 From: Olga Traczyk Date: Tue, 7 Feb 2017 15:43:58 +0100 Subject: [PATCH 1/2] hello-world: Modify tests to reject name == "" comparison --- exercises/hello-world/src/test/java/HelloWorldTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/hello-world/src/test/java/HelloWorldTest.java b/exercises/hello-world/src/test/java/HelloWorldTest.java index 6e1c545e5..52f4eb345 100644 --- a/exercises/hello-world/src/test/java/HelloWorldTest.java +++ b/exercises/hello-world/src/test/java/HelloWorldTest.java @@ -8,7 +8,7 @@ public class HelloWorldTest { @Test public void helloNoName() { - assertEquals("Hello, World!", HelloWorld.hello("")); + assertEquals("Hello, World!", HelloWorld.hello(new String(""))); assertEquals("Hello, World!", HelloWorld.hello(null)); } From 3586e06c3ba99e5f75580505188ee2c8bfed309a Mon Sep 17 00:00:00 2001 From: Olga Traczyk Date: Thu, 9 Feb 2017 13:22:36 +0100 Subject: [PATCH 2/2] hello-world: Add emptyStringIsComparedByValue() test case --- exercises/hello-world/src/test/java/HelloWorldTest.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/exercises/hello-world/src/test/java/HelloWorldTest.java b/exercises/hello-world/src/test/java/HelloWorldTest.java index 52f4eb345..d165bead1 100644 --- a/exercises/hello-world/src/test/java/HelloWorldTest.java +++ b/exercises/hello-world/src/test/java/HelloWorldTest.java @@ -8,10 +8,16 @@ public class HelloWorldTest { @Test public void helloNoName() { - assertEquals("Hello, World!", HelloWorld.hello(new String(""))); + assertEquals("Hello, World!", HelloWorld.hello("")); assertEquals("Hello, World!", HelloWorld.hello(null)); } + @Test + @Ignore + public void emptyStringIsComparedByValue() { + assertEquals("Hello, World!", HelloWorld.hello(new String(""))); + } + @Test @Ignore public void helloSampleName() {