prevent memory leaks in slice buffer

eikenb · eikenb · commit a741a7f1d522 · 2018-11-20T16:35:28.000-08:00
Remove reference to packets from packet ordering slices to prevent
small memory leak. The leak is bounded and temporary, but this is a good
practice.
diff --git a/packet-manager.go b/packet-manager.go
@@ -176,8 +176,10 @@ func (s *packetManager) maybeSendPackets() {
 			s.sender.sendPacket(out.(encoding.BinaryMarshaler))
 			// pop off heads
 			copy(s.incoming, s.incoming[1:])            // shift left
+			s.incoming[len(s.incoming)-1] = nil         // clear last
 			s.incoming = s.incoming[:len(s.incoming)-1] // remove last
 			copy(s.outgoing, s.outgoing[1:])            // shift left
+			s.outgoing[len(s.outgoing)-1] = nil         // clear last
 			s.outgoing = s.outgoing[:len(s.outgoing)-1] // remove last
 		} else {
 			break
