this makes more sense as cleanup of serveLoop()

puellanivis · puellanivis · commit 161b43cdfc9c · 2020-07-18T20:02:25.000Z
diff --git a/request-server.go b/request-server.go
@@ -107,6 +107,8 @@ func (rs *RequestServer) closeRequest(handle string) error {
 func (rs *RequestServer) Close() error { return rs.conn.Close() }
 
 func (rs *RequestServer) serveLoop(pktChan chan<- orderedRequest) error {
+	defer close(pktChan) // shuts down sftpServerWorkers
+
 	var err error
 	var pkt requestPacket
 	var pktType uint8
@@ -158,8 +160,7 @@ func (rs *RequestServer) Serve() error {
 
 	err := rs.serveLoop(pktChan)
 
-	close(pktChan) // shuts down sftpServerWorkers
-	wg.Wait()      // wait for all workers to exit
+	wg.Wait() // wait for all workers to exit
 
 	rs.openRequestLock.Lock()
 	defer rs.openRequestLock.Unlock()
