cleanPath: use path.IsAbs after converting ToSlash

drakkan · drakkan · commit 118ca5720446 · 2020-07-05T22:18:13.000+02:00
we need a POSIX path filepath.IsAbs can give unexpected results on Windows
diff --git a/request-server.go b/request-server.go
@@ -258,7 +258,7 @@ func cleanPacketPath(pkt *sshFxpRealpathPacket) responsePacket {
 // Makes sure we have a clean POSIX (/) absolute path to work with
 func cleanPath(p string) string {
 	p = filepath.ToSlash(p)
-	if !filepath.IsAbs(p) {
+	if !path.IsAbs(p) {
 		p = "/" + p
 	}
 	return path.Clean(p)

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ func cleanPacketPath(pkt *sshFxpRealpathPacket) responsePacket {`
`258`	`258`	`// Makes sure we have a clean POSIX (/) absolute path to work with`
`259`	`259`	`func cleanPath(p string) string {`
`260`	`260`	`p = filepath.ToSlash(p)`
`261`		`- if !filepath.IsAbs(p) {`
	`261`	`+ if !path.IsAbs(p) {`
`262`	`262`	`p = "/" + p`
`263`	`263`	`}`
`264`	`264`	`return path.Clean(p)`