8000 doc: Move contributing docs into default makefile target · etherscan-io/sentry-python@c359d69 · GitHub
[go: up one dir, main page]

Skip to content

Commit c359d69

Browse files
committed
doc: Move contributing docs into default makefile target
1 parent bd0aa9b commit c359d69

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,10 @@ changes manually.
77
## Running tests and linters
88

99
Make sure you have `virtualenv` installed, and the Python versions you care
10-
about. You should have at least one version of Python 2 and Python 3 installed.
10+
about. You should have Python 2.7 and the latest Python 3 installed.
1111

1212
You don't need to `workon` or `activate` anything, the `Makefile` will create
13-
one for you.
14-
15-
* Running basic tests without integrations: `make test` (Python 2.7 and 3.7)
16-
* Running all tests: `make test-all`
17-
18-
This really runs all tests, for all integrations, for all version
19-
combinations we care about. This is the closest you can get to the CI build,
20-
provided you have all relevant Python versions installed.
21-
22-
* Running linting: `make check` or `make lint`
23-
* Running autoformatting: `make format`
13+
one for you. Run `make` or `make help` to list commands.
2414

2515
## Releasing a new version
2616

Makefile

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,17 @@ SHELL = /bin/bash
22

33
VENV_PATH = .venv
44

5+
help:
6+
@echo "Thanks for your interest in the Sentry Python SDK!"
7+
@echo
8+
@echo "make lint: Run linters"
9+
@echo "make test: Run basic tests (not testing most integrations)"
10+
@echo "make test-all: Run ALL tests (slow, closest to CI)"
11+
@echo "make format: Run code formatters (destructive)"
12+
@echo
13+
@echo "Also make sure to read ./CONTRIBUTING.md"
14+
@false
15+
516
.venv:
617
virtualenv $(VENV_PATH)
718
$(VENV_PATH)/bin/pip install tox
@@ -25,7 +36,7 @@ test-all: .venv
2536
@TOXPATH=$(VENV_PATH)/bin/tox sh ./scripts/runtox.sh
2637
.PHONY: test-all
2738

28-
check: lint
39+
check: lint test
2940
.PHONY: check
3041

3142
lint: .venv

0 commit comments

Comments
 (0)
0