fix: Don't use event.stacktrace (getsentry#112)

untitaker · web-flow · commit 8aa0446c8b0c · 2018-10-09T12:48:21.000+02:00
diff --git a/sentry_sdk/client.py b/sentry_sdk/client.py
@@ -75,12 +75,19 @@ def _prepare_event(self, event, hint, scope):
                 return
 
         if (
-            "exception" not in event
+            self.options["attach_stacktrace"]
+            and "exception" not in event
             and "stacktrace" not in event
-            and self.options["attach_stacktrace"]
+            and "threads" not in event
         ):
             with capture_internal_exceptions():
-                event["stacktrace"] = current_stacktrace()
+                event["threads"] = [
+                    {
+                        "stacktrace": current_stacktrace(),
+                        "crashed": False,
+                        "current": True,
+                    }
+                ]
 
         for key in "release", "environment", "server_name", "dist":
             if event.get(key) is None:
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -105,7 +105,8 @@ def bar():
     foo()
 
     event, = events
-    functions = [x["function"] for x in event["stacktrace"]["frames"]]
+    thread, = event["threads"]
+    functions = [x["function"] for x in thread["stacktrace"]["frames"]]
     assert functions[-2:] == ["foo", "bar"]
 
 
@@ -115,7 +116,7 @@ def test_attach_stacktrace_disabled():
     hub.capture_message("HI")
 
     event, = events
-    assert "stacktrace" not in event
+    assert "threads" not in event
 
 
 def test_capture_event_works():
