fix: Send chained exceptions in the correct order

untitaker · untitaker · commit 5df96a290e3e · 2019-04-18T10:39:39.000+02:00
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -569,6 +569,9 @@ def exceptions_from_error_tuple(
                 exc_type, exc_value, tb, client_options, mechanism
             )
         )
+
+    rv.reverse()
+
     return rv
 
 
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -419,15 +419,21 @@ def test_chained_exceptions(sentry_init, capture_events):
 
     try:
         try:
-            1 / 0
+            raise ValueError()
         except Exception:
             1 / 0
     except Exception:
         capture_exception()
 
     event, = events
 
-    assert len(event["exception"]["values"]) == 2
+    e1, e2 = event["exception"]["values"]
+
+    # This is the order all other SDKs send chained exceptions in. Including
+    # Raven-Python.
+
+    assert e1["type"] == "ValueError"
+    assert e2["type"] == "ZeroDivisionError"
 
 
 @pytest.mark.tests_internal_exceptions

Original file line number	Diff line number	Diff line change
`@@ -569,6 +569,9 @@ def exceptions_from_error_tuple(`
`569`	`569`	`exc_type, exc_value, tb, 10043 client_options, mechanism`
`570`	`570`	`)`
`571`	`571`	`)`
	`572`	`+`
	`573`	`+ rv.reverse()`
	`574`	`+`
`572`	`575`	`return rv`
`573`	`576`
`574`	`577`