fix: PII bugs in _wsgi, ignore django.server logger

untitaker · untitaker · commit 067ea9225525 · 2018-11-05T11:07:30.000+01:00
diff --git a/sentry_sdk/integrations/_wsgi.py b/sentry_sdk/integrations/_wsgi.py
@@ -14,7 +14,11 @@ def get_environ(environ):
     """
     Returns our whitelisted environment variables.
     """
-    for key in ("REMOTE_ADDR", "SERVER_NAME", "SERVER_PORT"):
+    keys = ("SERVER_NAME", "SERVER_PORT")
+    if _should_send_default_pii():
+        keys += ("REMOTE_ADDR",)
+
+    for key in keys:
         if key in environ:
             yield key, environ[key]
 
diff --git a/sentry_sdk/integrations/django/__init__.py b/sentry_sdk/integrations/django/__init__.py
@@ -60,6 +60,9 @@ def setup_once():
         install_sql_hook()
         # Patch in our custom middleware.
 
+        # logs an error for every 500
+        ignore_logger("django.server")
+
         from django.core.handlers.wsgi import WSGIHandler
 
         old_app = WSGIHandler.__call__
