fix: Never send NaN

untitaker · untitaker · commit 022509ac0e37 · 2018-12-14T10:52:22.000-08:00
diff --git a/sentry_sdk/transport.py b/sentry_sdk/transport.py
@@ -112,7 +112,7 @@ def _send_event(self, event):
 
         body = io.BytesIO()
         with gzip.GzipFile(fileobj=body, mode="w") as f:
-            f.write(json.dumps(event).encode("utf-8"))
+            f.write(json.dumps(event, allow_nan=False).encode("utf-8"))
 
         logger.debug(
             "Sending %s event [%s] to %s project:%s"
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -8,7 +8,14 @@
 
 from datetime import datetime
 from textwrap import dedent
-from sentry_sdk import Hub, Client, configure_scope, capture_message, add_breadcrumb
+from sentry_sdk import (
+    Hub,
+    Client,
+    configure_scope,
+    capture_message,
+    add_breadcrumb,
+    capture_exception,
+)
 from sentry_sdk.hub import HubMeta
 from sentry_sdk.transport import Transport
 from sentry_sdk._compat import reraise, text_type
@@ -290,3 +297,19 @@ def test_weird_chars(sentry_init, capture_events):
     capture_message(u"föö".encode("latin1"))
     event, = events
     assert json.loads(json.dumps(event)) == event
+
+
+def test_nan(sentry_init, capture_events):
+    sentry_init()
+    events = capture_events()
+
+    try:
+        nan = float("nan")  # noqa
+        1 / 0
+    except Exception:
+        capture_exception()
+
+    event, = events
+    frames = event["exception"]["values"][0]["stacktrace"]["frames"]
+    frame, = frames
+    assert frame["vars"]["nan"] == "nan"
