8000 BUG: softAPdisconnect return value corruption · Issue #3795 · esp8266/Arduino · GitHub
[go: up one dir, main page]

Skip to content
BUG: softAPdisconnect return value corruption #3795
Closed
@tablatronix

Description

@tablatronix

Basic Infos

Hardware

Hardware: ESP12e (nodemcu)
Core Version: 2.1.0-rc2

Description

softAPdisconnect return value gets ovewritten when wifioff is true

Sketch

// source
bool ESP8266WiFiAPClass::softAPdisconnect(bool wifioff) {
    bool ret;
    struct softap_config conf;
    *conf.ssid = 0;
    *conf.password = 0;

    ETS_UART_INTR_DISABLE();
    if(WiFi._persistent) {
        ret = wifi_softap_set_config(&conf);
    } else {
        ret = wifi_softap_set_config_current(&conf);
    }
    ETS_UART_INTR_ENABLE();

    if(!ret) {
        DEBUG_WIFI("[APdisconnect] set_config failed!\n");
    }

    if(wifioff) {
        ret = WiFi.enableAP(false); // overwrites ret!!!!
    }

    return ret;
}

if wifi_softap_set_config(_current) returns false and wifioff is true, function will return true (if enableap suceeds of course)

Should bail if if ret is false

    if(ret && wifioff) {
        ret = WiFi.enableAP(false);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0