Abort if BearSSL stack allocation fails (#7152)

earlephilhower · web-flow · commit db75d2c448bf · 2020-03-15T11:56:23.000-07:00
As found by @d-a-v, if the malloc() used to get the BearSSL stack does not succeed, abort() immediately.
diff --git a/cores/esp8266/StackThunk.cpp b/cores/esp8266/StackThunk.cpp
@@ -26,6 +26,9 @@
 
 #include <stdint.h>
 #include <stdlib.h>
+#include <stdio.h>
+#include "pgmspace.h"
+#include "debug.h"
 #include "StackThunk.h"
 #include <ets_sys.h>
 
@@ -46,6 +49,11 @@ void stack_thunk_add_ref()
   stack_thunk_refcnt++;
   if (stack_thunk_refcnt == 1) {
     stack_thunk_ptr = (uint32_t *)malloc(_stackSize * sizeof(uint32_t));
+    if (!stack_thunk_ptr) {
+        // This is a fatal error, stop the sketch
+        DEBUGV("Unable to allocate BearSSL stack\n");
+        abort();
+    }
     stack_thunk_top = stack_thunk_ptr + _stackSize - 1;
     stack_thunk_save = NULL;
     stack_thunk_repaint();
