8000 minor #34561 Remove some unused methods parameters (fancyweb) · eskylake/symfony@df6c635 · GitHub
[go: up one dir, main page]
Skip to content

Commit df6c635

Browse files
fabpotfabpot
committed
minor symfony#34561 Remove some unused methods parameters (fancyweb)
This PR was merged into the 3.4 branch. Discussion ---------- Remove some unused methods parameters | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR removes some useless private method parameters. Commits ------- 026730e Remove some unused methods parameters
2 parents 7d87ebc + 026730e commit df6c635

File tree

5 files changed

+12
-13
lines changed

5 files changed

+12
-13
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php

Lines changed: 10000 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ protected function describeEventDispatcherListeners(EventDispatcherInterface $ev
166166
*/
167167
protected function describeCallable($callable, array $options = [])
168168
{
169-
$this->writeData($this->getCallableData($callable, $options), $options);
169+
$this->writeData($this->getCallableData($callable), $options);
170170
}
171171

172172
/**
@@ -321,7 +321,7 @@ private function getEventDispatcherListenersData(EventDispatcherInterface $event
321321
*
322322
* @return array
323323
*/
324-
private function getCallableData($callable, array $options = [])
324+
private function getCallableData($callable)
325325
{
326326
$data = [];
327327

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ private function createEncoders($encoders, ContainerBuilder $container)
585585
{
586586
$encoderMap = [];
587587
foreach ($encoders as $class => $encoder) {
588-
$encoderMap[$class] = $this->createEncoder($encoder, $container);
588+
$encoderMap[$class] = $this->createEncoder($encoder);
589589
}
590590

591591
$container
@@ -594,7 +594,7 @@ private function createEncoders($encoders, ContainerBuilder $container)
594594
;
595595
}
596596

597-
private function createEncoder($config, ContainerBuilder $container)
597+
private function createEncoder($config)
598598
{
599599
// a custom encoder service
600600
if (isset($config['id'])) {

‎src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
114114
continue;
115115
}
116116

117-
$this->displayLog($input, $output, $clientId, $record);
117+
$this->displayLog($output, $clientId, $record);
118118
}
119119
}
120120

@@ -141,7 +141,7 @@ private function getLogs($socket)
141141
}
142142
}
143143

144-
private function displayLog(InputInterface $input, OutputInterface $output, $clientId, array $record)
144+
private function displayLog(OutputInterface $output, $clientId, array $record)
145145
{
146146
if ($this->handler->isHandling($record)) {
147147
if (isset($record['log_id'])) {

‎src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ private function parseDefinition(\DOMElement $service, $file, array $defaults)
278278
$definition->setDeprecated(true, $deprecated[0]->nodeValue ?: null);
279279
}
280280

281-
$definition->setArguments($this->getArgumentsAsPhp($service, 'argument', $file, false, $definition instanceof ChildDefinition));
281+
$definition->setArguments($this->getArgumentsAsPhp($service, 'argument', $file, $definition instanceof ChildDefinition));
282282
$definition->setProperties($this->getArgumentsAsPhp($service, 'property', $file));
283283

284284
if ($factories = $this->getChildren($service, 'factory')) {
@@ -452,11 +452,10 @@ private function processAnonymousServices(\DOMDocument $xml, $file, $defaults)
452452
*
453453
* @param string $name
454454
* @param string $file
455-
* @param bool $lowercase
456455
*
457456
* @return mixed
458457
*/
459-
private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase = true, $isChildDefinition = false)
458+
private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $isChildDefinition = false)
460459
{
461460
$arguments = [];
462461
foreach ($this->getChildren($node, $name) as $arg) {
@@ -506,10 +505,10 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =
506505
$arguments[$key] = new Expression($arg->nodeValue);
507506
break;
508507
case 'collection':
509-
$arguments[$key] = $this->getArgumentsAsPhp($arg, $name, $file, false);
508+
$arguments[$key] = $this->getArgumentsAsPhp($arg, $name, $file);
510509
break;
511510
case 'iterator':
512-
$arg = $this->getArgumentsAsPhp($arg, $name, $file, false);
511+
$arg = $this->getArgumentsAsPhp($arg, $name, $file);
513512
try {
514513
$arguments[$key] = new IteratorArgument($arg);
515514
} catch (InvalidArgumentException $e) {

‎src/Symfony/Component/Translation/Dumper/XliffFileDumper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
4141
return $this->dumpXliff1($defaultLocale, $messages, $domain, $options);
4242
}
4343
if ('2.0' === $xliffVersion) {
44-
return $this->dumpXliff2($defaultLocale, $messages, $domain, $options);
44+
return $this->dumpXliff2($defaultLocale, $messages, $domain);
4545
}
4646

4747
throw new InvalidArgumentException(sprintf('No support implemented for dumping XLIFF version "%s".', $xliffVersion));
@@ -129,7 +129,7 @@ private function dumpXliff1($defaultLocale, MessageCatalogue $messages, $domain,
129129
return $dom->saveXML();
130130
}
131131

132-
private function dumpXliff2($defaultLocale, MessageCatalogue $messages, $domain, array $options = [])
132+
private function dumpXliff2($defaultLocale, MessageCatalogue $messages, $domain)
133133
{
134134
$dom = new \DOMDocument('1.0', 'utf-8');
135135
$dom->formatOutput = true;

0 commit comments

Comments
 (0)
0