sp_HumanEvents - Refactor To Remove LOWER(@event_type)

Is your feature request related to a problem? Please describe.
Would you be open to setting @event_type to LOWER further up the in the code? Or maybe refactor with a new variable which LOWER-ed @event_type ( i.e. @event_type_lower )? Then I can remove all the LOWER(@event_type) in the code? ( NOTE: I did find one LOWER()that was missed onobject_name. Some of that codemay change with theLIKE` implementation though ).

DarlingData/sp_HumanEvents/sp_HumanEvents.sql

Lines 1290 to 1301 in c375e40

    
           IF @object_name <> N'' 
        
           BEGIN 
        
               IF @event_type LIKE N'%lock%' 
        
               BEGIN 
        
                   SET @object_id = OBJECT_ID(@fully_formed_babby); 
        
                   SET @object_name_filter += N'     AND object_id = ' + @object_id + @nc10; 
        
               END; 
        
               IF @event_type NOT LIKE N'%lock%' 
        
               BEGIN 
        
                   SET @object_name_filter += N'     AND object_name = N' + QUOTENAME(@object_name, N'''') + @nc10; 
        
               END; 
        
           END;

Describe the solution you'd like
Override the parameter variable.

Describe alternatives you've considered
New variable

Are you ready to build the code for the feature?
Yes I can do the refactor.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`sp_HumanEvents` - Refactor To Remove `LOWER(@event_type)` #640

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	IF @object_name <> N''
	BEGIN
	IF @event_type LIKE N'%lock%'
	BEGIN
	SET @object_id = OBJECT_ID(@fully_formed_babby);
	SET @object_name_filter += N' AND object_id = ' + @object_id + @nc10;
	END;
	IF @event_type NOT LIKE N'%lock%'
	BEGIN
	SET @object_name_filter += N' AND object_name = N' + QUOTENAME(@object_name, N'''') + @nc10;
	END;
	END;

sp_HumanEvents - Refactor To Remove LOWER(@event_type) #640

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`sp_HumanEvents` - Refactor To Remove `LOWER(@event_type)` #640