Merge pull request numpy#11899 from tylerjereddy/rm_exec_command_3

charris · web-flow · commit f5838d072f18 · 2018-09-10T19:44:14.000-05:00
MAINT: remove exec_command from system_info.py
diff --git a/doc/release/1.16.0-notes.rst b/doc/release/1.16.0-notes.rst
@@ -66,6 +66,13 @@ New Features
 Improvements
 ============
 
+build shell independence
+------------------------
+NumPy builds should no longer interact with the host machine
+shell directly. ``exec_command`` has been replaced with
+``subprocess.check_output`` where appropriate.
+
+
 `np.polynomial.Polynomial` classes render in LaTeX in Jupyter notebooks
 -----------------------------------------------------------------------
 
diff --git a/numpy/distutils/system_info.py b/numpy/distutils/system_info.py
@@ -147,7 +147,8 @@
 from distutils.util import get_platform
 
 from numpy.distutils.exec_command import (
-    find_executable, exec_command, get_pythonexe)
+    find_executable, filepath_from_subprocess_output,
+    get_pythonexe)
 from numpy.distutils.misc_util import (is_sequence, is_string,
                                        get_shared_lib_extension)
 from numpy.distutils.command.config import config as cmd_config
@@ -2243,8 +2244,12 @@ def get_config_exe(self):
 
     def get_config_output(self, config_exe, option):
         cmd = config_exe + ' ' + self.append_config_exe + ' ' + option
-        s, o = exec_command(cmd, use_tee=0)
-        if not s:
+        try:
+            o = subprocess.check_output(cmd)
+        except (OSError, subprocess.CalledProcessError):
+            pass
+        else:
+            o = filepath_from_subprocess_output(o)
             return o
 
     def calc_info(self):
