bug symfony#20010 [DX] Fixed regression when exception message swallowed when logging it. (Koc)

fabpot · fabpot · commit d8423071deed · 2016-09-21T10:05:38.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [DX] Fixed regression when exception message swallowed when logging it. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | maybe, wait for Travis | Fixed tickets | fixed regression introduced in symfony#13418 | License | MIT | Doc PR | - The problem is: after merging referenced PR we cann't understand what error occured and why authentication request failed (see attached screenshot). Previously it displays exception message, but now it only displays class of the exception. ![9003644109](https://cloud.githubusercontent.com/assets/191082/18717550/f0df61c4-8028-11e6-8dbb-684e4928e913.jpg) Commits ------- 042cb6b Fixed regression when exception message swallowed when logging it.
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
@@ -147,6 +147,10 @@ private function sanitizeContext($context)
         }
 
         if (is_object($context)) {
+            if ($context instanceof \Exception) {
+                return sprintf('Exception(%s): %s', get_class($context), $context->getMessage());
+            }
+
             return sprintf('Object(%s)', get_class($context));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,10 @@ private function sanitizeContext($context)`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`if (is_object($context)) {`
	`150`	`+ if ($context instanceof \Exception) {`
	`151`	`+ return sprintf('Exception(%s): %s', get_class($context), $context->getMessage());`
	`152`	`+ }`
	`153`	`+`
`150`	`154`	`return sprintf('Object(%s)', get_class($context));`
`151`	`155`	`}`
`152`	`156`