Pyright complains about typing of middleware argument in constructor #2451
Replies: 3 comments 11 replies
-
|
I can't reproduce it. Are you in the latest pyright version? |
Beta Was this translation helpful? Give feedback.
-
|
Looks like I'm facing the same issue, even without any extra instruments. The problem is that in the commit 866a15f there was a change for type hinting from middleware_class: type,to middleware_class: typing.Type[_MiddlewareClass[P]],So it waits for middlewares to be inherited from _MiddlewareClass, what is wrong I believe. From the docs: from starlette.applications import Starlette
from starlette.middleware.base import BaseHTTPMiddleware
class CustomMiddleware(BaseHTTPMiddleware):
async def dispatch(self, request, call_next):
response = await call_next(request)
response.headers['Custom-Header'] = 'Example'
return response
app = Starlette()
app.add_middleware(CustomMiddleware)Gives: Environment: |
Beta Was this translation helpful? Give feedback.
-
I also see this issue using a Jetbrains editor, such as Idea or Pycharm. Note that the middleware is |
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed now... Is it? I can't reproduce it. |
Beta Was this translation helpful? Give feedback.
-
|
This seems to be fixed in |
Beta Was this translation helpful? Give feedback.
-
Hey! We are on 0.46.1 right now, and we still have the same issue. |
Beta Was this translation helpful? Give feedback.
-
|
I have a similar error popping up, I've made an Issue over on asgi-loggers' repo documenting my case. Since I posted, I figured out it started since commit 866a15. |
Beta Was this translation helpful? Give feedback.
-
|
I am facing the same issue in FastAPI. I have made this middleware and when I use it like this: I get the warning related to type mismatch. |
Beta Was this translation helpful? Give feedback.
-
For now now, I described why this happens here Or you can use cast, but it's better to use noqa ) |
Beta Was this translation helpful? Give feedback.
-
|
Anybody found a solution for this? |
Beta Was this translation helpful? Give feedback.
-
|
I have no issue with mypy 1.14.1. What's the problem here? |
Beta Was this translation helpful? Give feedback.
-
|
I'm getting the error reported there: https://github.com/encode/starlette/discussions/2451#discussioncomment-8316875 |
Beta Was this translation helpful? Give feedback.
-
|
I have same problem |
Beta Was this translation helpful? Give feedback.
- 57AE
-
Error reported independently by both
pyrightand the pycharm type-checker, I assume it is also caught bymypy.Repro example:
Errors reported by pyright:
Beta Was this translation helpful? Give feedback.
All reactions