Custom validation method #9464

mhdemd · 2024-07-09T13:15:57Z

mhdemd
Jul 9, 2024

Describe the bug
When using a custom validation method validate_price in a serializer to enforce specific validation rules for a DecimalField, the default validation messages from Django are shown instead of the custom validation messages provided in the method.

To Reproduce
Steps to reproduce the behavior:

Create a serializer with a DecimalField and a custom validation method for this field.
Trigger validation errors for the field.
Observe that the default validation messages from Django are shown instead of the custom messages.

Expected behavior
The custom validation messages defined in the validate_price method should be shown when the validation fails.

Code Snippet

from rest_framework import serializers
from .models import Product

class ProductSerializer(serializers.ModelSerializer):
    class Meta:
        model = Product
        fields = ['id', 'name', 'price']
    
    def validate_price(self, value):
        if value < 5:
            raise serializers.ValidationError("Price must be at least 5.")
        if value.as_tuple().exponent < -1:
            raise serializers.ValidationError("Price cannot have more than 1 decimal places.")
        if len(str(value).replace('.', '')) > 5:
            raise serializers.ValidationError("Price cannot have more than 5 digits in total.")
        return value

# In the code snippet above, when the price is less than 5, the custom error message "Price must be at least 5." is shown correctly.
# However, for the other two validation checks, the default Django validation messages are shown instead of the custom messages.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Custom validation method #9464

Uh oh!

{{title}}

Uh oh!

Replies: 0 comments

Select a reply

Uh oh!

Uh oh!

Custom validation method #9464

Uh oh!

mhdemd Jul 9, 2024

Replies: 0 comments

mhdemd
Jul 9, 2024