Don't leak connections when authentication fails.

alaisi · alaisi · commit 769f5693c9af · 2015-11-04T11:29:37.000+02:00
diff --git a/src/main/java/com/github/pgasync/impl/PgConnectionPool.java b/src/main/java/com/github/pgasync/impl/PgConnectionPool.java
@@ -169,6 +169,7 @@ public Observable<Connection> getConnection() {
 
                 new PgConnection(openStream(address), dataConverter)
                         .connect(username, password, database)
+                        .doOnError(__ -> release(null))
                         .subscribe(subscriber);
             } finally {
                 if (locked) {
@@ -200,7 +201,7 @@ private void releaseIfNotPipelining(Connection connection) {
 
     @Override
     public void release(Connection connection) {
-        boolean failed = !((PgConnection) connection).isConnected();
+        boolean failed = connection == null || !((PgConnection) connection).isConnected();
 
         Subscriber<? super Connection> next;
         lock.lock();
