Disable Codecov Check Run Annotations #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables check run annotations for codecov in the codecov.yml. This should prevent the ''X line not covered by tests'' annotations in PRs .
The current approach was becoming hard to maintain. This should make it easier to integrate new frameworks.
Our AWS Lambda test suite currently doesn't run properly on external contributor PRs because it needs access to repo secrets, which it currently doesn't have. This PR adds a label to grant access to the secrets, which is invalidated upon any new code changes.
) We were using the current SDK version for determining whether an AWS Lambda function should be reused, so e.g. on PRs, this would reuse the existing functions instead of creating new ones with any changes from the PR. Changing this to use the current commit instead. Also, use a 6 character hash instead of 5 characters, just to lower the chance for collisions a bit.
…tsentry#2546) When a lambda is triggered by an AWS EventBridge pipe the record contains an explicit "headers" key with an empty list. This breaks the assumption that headers is always a dict or None. Update the AwsLambdaIntegration to explicitly verify that header is a dict before passing it on to the `continue_trace` function. Fixes getsentryGH-2545 --------- Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Seems like the recent release of `pytest-asyncio` `0.23` broke some of our tests. Pinning it to unblock PRs.
…ry#2544) Moved some functionality from Hub to Scope or Client: - moved add_breadcrumb from Hub to Scope - moved session functions from Hub to Scope - moved get_integration1 from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.
--------- Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
* Made test non-flaky between different python versions
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
…etsentry#2394) This change adds support for cluster clients from the redis sdk (as opposed to the rediscluster library). This has also been tested in my own app which uses clusters (but not asyncio clusters). Fixes getsentryGH-2523 * feat(integrations): add support for cluster clients from redis sdk * fix: review round 1 * fix: explicit `is not None` checks * fix: explicit `is not None` checks, take 2 * fix: add try/except to _set_db_data * fix: handle additional spans and breadcrumbs caused by rediscluster initialization * fix: typing for redis integration * fix: simplify assertions * add `capture_internal_exceptions` Co-authored-by: Matthieu Devlin <matt@zumper.com> * rerun CI --------- Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
…etsentry#2544)" (getsentry#2574) This reverts commit 354d7bb.
…entry#2575) * Fix Celery `TypeError` with no-argument `apply_async` * Verify the task actually executed
This will prevent the streaming reponse OpenAI tests to fail.
End-users may need to use the Event type for their type hinting to work following the Event type changes. However, we define Event in a private module sentry_sdk._types, which provides no stability guarantees. Therefore, this PR creates a new public module sentry_sdk.types, where we re-export the Event type, and explicitly make it available as public API via sentry_sdk.types.Event. The new sentry_sdk.types module includes a docstring to inform users that we reserve the right to modify types in minor releases, since we consider types to be a form of documentation (they are not enforced by the Python language), but that we guarantee that we will only remove type definitions in a major release.
This PR makes sure all apidocs are recreated always (by deleting an eventually existing docs/_build folder) and also adds some minor changes to set_level and set_tag to make the types of parameters clear.
…try#2643) --------- Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
…etsentry#2832) Bumps [checkouts/data-schemas](https://github.com/getsentry/sentry-data-schemas) from `ed078ed` to `8232f17`. - [Commits](getsentry/sentry-data-schemas@ed078ed...8232f17) --- updated-dependencies: - dependency-name: checkouts/data-schemas dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
As per getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in getsentry#2830.
…etsentry#2901) Bumps [checkouts/data-schemas](https://github.com/getsentry/sentry-data-schemas) from `8232f17` to `1e17eb5`. - [Commits](getsentry/sentry-data-schemas@8232f17...1e17eb5) --- updated-dependencies: - dependency-name: checkouts/data-schemas dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Explicitly reexport types to make strict mypy setups happy. This backports getsentry#2866 to 1.x. Fixes getsentryGH-2910 Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Set types in sentry_sdk.types to None at runtime. This allows the types to be imported from outside if TYPE_CHECKING guards. Fixes getsentryGH-2909 Co-authored-by: Anton Pirker <anton.pirker@sentry.io> Co-authored-by: anthony sottile & B41A lt;103459774+asottile-sentry@users.noreply.github.com>
Change Event's runtime value to typing.Any, since the previous value of None caused the expression Event | None to result in a TypeError at runtime, even when the Event | None expression was used as a type hint. Also, add a test to make sure we don't reintroduce this bug. Fixes getsentryGH-2926
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
In Sanic some exceptions are "quiet" (https://github.com/hamedsh/sanic/blob/b8ec9ed3e6f63f4c61fd45d3e09cfc9457a53b82/sanic/exceptions.py#L9) These exceptions, do not get logged in stderror and should also not be sent to Sentry. --------- Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
…try#2761) Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables check run annotations for codecov in the codecov.yml. This should prevent the ''X line not covered by tests'' annotations in PRs .