Only warn about html() method once

electrikmilk · electrikmilk · commit 233986359526 · 2023-09-08T23:10:04.000-04:00
diff --git a/src/base-element.js b/src/base-element.js
@@ -3,6 +3,7 @@
  */
 
 let references = {};
+let htmlWarn = false;
 
 export class BaseElement {
     element;
@@ -111,8 +112,9 @@ export class BaseElement {
     }
 
     html(html) {
-        if (import.meta.env.DEV) {
+        if (import.meta.env.DEV && !htmlWarn) {
             console.warn('Do not use the html() method to render user generated content. This creates a risk of cross-site scripting (XSS) attacks.');
+            htmlWarn = true;
         }
         return this.property('innerHTML', html);
     }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`*/`
`4`	`4`
`5`	`5`	`let references = {};`
	`6`	`+let htmlWarn = false;`
`6`	`7`
`7`	`8`	`export class BaseElement {`
`8`	`9`	`element;`
`@@ -111,8 +112,9 @@ export class BaseElement {`
`111`	`112`	`}`
`112`	`113`
`113`	`114`	`html(html) {`
`114`		`- if (import.meta.env.DEV) {`
	`115`	`+ if (import.meta.env.DEV && !htmlWarn) {`
`115`	`116`	`console.warn('Do not use the html() method to render user generated content. This creates a risk of cross-site scripting (XSS) attacks.');`
	`117`	`+ htmlWarn = true;`
`116`	`118`	`}`
`117`	`119`	`return this.property('innerHTML', html);`
`118`	`120`	`}`