Merge pull request ruby#128 from Shopify/fix-graphviz

maximecb · web-flow · commit 5ead1aeacc96 · 2021-07-15T17:09:42.000-04:00
Dup strings so we can mutate them
diff --git a/yjit.rb b/yjit.rb
@@ -63,7 +63,7 @@ def self.graphviz_for(iseq)
       highlight = ->(comment) { "<b>#{comment}</b>" }
       linebreak = "<br align=\"left\"/>\n"
 
-      buff = ''
+      buff = +''
       blocks = blocks_for(iseq).sort_by(&:id)
       buff << "digraph g {\n"
 
@@ -103,7 +103,7 @@ def self.graphviz_for(iseq)
     def self.disasm_block(cs, block, highlight)
       comments = comments_for(block.address, block.address + block.code.length)
       comment_idx = 0
-      str = ''
+      str = +''
       cs.disasm(block.code, block.address).each do |i|
         while (comment = comments[comment_idx]) && comment.address <= i.address
           str << "  ; #{highlight.call(comment.comment)}\n"
