Reduce the chance of hitting the same endpoint over and over when reconnecting

michaelklishin · michaelklishin · commit 12495f50c051 · 2016-01-25T17:16:59.000+03:00
Constant re-shuffling produced confusing effects in that there was a chance of 3-4 re-connections to the same (often unreachable in practice) endpoint. Fixes rabbitmq#124.
diff --git a/src/com/rabbitmq/client/impl/recovery/RecoveryAwareAMQConnectionFactory.java b/src/com/rabbitmq/client/impl/recovery/RecoveryAwareAMQConnectionFactory.java
@@ -29,7 +29,8 @@ public RecoveryAwareAMQConnectionFactory(ConnectionParams params, FrameHandlerFa
      */
     RecoveryAwareAMQConnection newConnection() throws IOException, TimeoutException {
         IOException lastException = null;
-        for (Address addr : shuffle(addrs)) {
+        Address[] shuffled = shuffle(addrs);
+        for (Address addr : shuffled) {
             try {
                 FrameHandler frameHandler = factory.create(addr);
                 RecoveryAwareAMQConnection conn = new RecoveryAwareAMQConnection(params, frameHandler);
