10000 macros are broken unless import is manually added · Issue #6 · edheltzel/flightdeck-esbuild · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros are broken unless import is manually added #6

Closed
edheltzel opened this issue Jul 17, 2022 · 2 comments
Closed

macros are broken unless import is manually added #6

edheltzel opened this issue Jul 17, 2022 · 2 comments
Assignees
@edheltzel
Labels
bug 🐛 Something isn't working enhancement 💡 New feature / request / ideas

Comments

@edheltzel
Copy link
Owner
edheltzel commented Jul 17, 2022 •
edited
Loading

macros will cause 11ty to error in the console and not rebuild due to how 11ty handles nunjuck template inheritance which is slightly different than "vanilla" Nunjucks.

Ideally, there would be a global import so macros would only need to use a single import for all components that live under the components/ directory.

{% from 'macros/component.njk' import component %}

<!-- component usage -->
{{ component('blockquote', {
  text:'This is a blockquote using a <strong>macro</strong>',
  source: '<a href="https://github.com/11ty/eleventy/issues/613">Issue #613</a>'}) }}

This is only an attempt to keep everything in the spirit of Flightdeck, where Eleventy is at the helm with the least amount of friction for the developer experience.
@edheltzel edheltzel added bug 🐛 Something isn't working enhancement 💡 New feature / request / ideas labels Jul 17, 2022
@edheltzel edheltzel self-assigned this Jul 17, 2022
@edheltzel
Copy link
Owner Author

11ty/eleventy#613

@edheltzel
Copy link
Owner Author
edheltzel commented Sep 18, 2023 •
edited
Loading

possible solution: 11ty/eleventy#613 (comment)

Going to shelf this issue and add it to the roadmap as an 11ty plugin

@edheltzel edheltzel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edheltzel edheltzel

Labels
bug 🐛 Something isn't working enhancement 💡 New feature / request / ideas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edheltzel
0