Make Timestamp hashable (msgpack#396)

methane · web-flow · commit 9e5ec95e0292 · 2019-12-12T19:59:06.000+09:00
When overriding __eq__, __hash__ should be overridden too.
diff --git a/msgpack/ext.py b/msgpack/ext.py
@@ -36,6 +36,8 @@ class Timestamp(object):
 
     When built with Cython, msgpack uses C methods to pack and unpack `Timestamp`. When using pure-Python
     msgpack, :func:`to_bytes` and :func:`from_bytes` are used to pack and unpack `Timestamp`.
+
+    This class is immutable: Do not override seconds and nanoseconds.
     """
 
     __slots__ = ["seconds", "nanoseconds"]
@@ -78,9 +80,8 @@ def __eq__(self, other):
             )
         return False
 
-    def __ne__(self, other):
-        """not-equals method (see :func:`__eq__()`)"""
-        return not self.__eq__(other)
+    def __hash__(self):
+        return hash((self.seconds, self.nanoseconds))
 
     @staticmethod
     def from_bytes(b):
