Fix file creation on SD and SDFS (#216)

earlephilhower · web-flow · commit 35c974d4c0fc · 2021-06-19T12:15:11.000-07:00
The O_CREAT/etc. flags on the Pico are a full 32-bits in size, but the core was generating a flag for SdFat using an 8-bit type, so all the O_CREAT, O_TRUNC, O_APPEND, etc. flags got cut off. Fix the flag size. Fixes #214
diff --git a/libraries/SDFS/src/SDFS.h b/libraries/SDFS/src/SDFS.h
@@ -234,8 +234,8 @@ class SDFSImpl : public FSImpl
     }
 
 
-    static uint8_t _getFlags(OpenMode openMode, AccessMode accessMode) {
-        uint8_t mode = 0;
+    static int _getFlags(OpenMode openMode, AccessMode accessMode) {
+        int mode = 0;
         if (openMode & OM_CREATE) {
             mode |= O_CREAT;
         }

Original file line number	Diff line number	Diff line change
`@@ -234,8 +234,8 @@ class SDFSImpl : public FSImpl`
`234`	`234`	`}`
`235`	`235`
`236`	`236`
`237`		`- static uint8_t _getFlags(OpenMode openMode, AccessMode accessMode) {`
`238`		`- uint8_t mode = 0;`
	`237`	`+ static int _getFlags(OpenMode openMode, AccessMode accessMode) {`
	`238`	`+ int mode = 0;`
`239`	`239`	`if (openMode & OM_CREATE) {`
`240`	`240`	`mode \|= O_CREAT;`
`241`	`241`	`}`