Draft
Conversation
Owner
|
This is good work, but I wonder if it would be more fruitful to copy musl's fnmatch implementation and add globstar support and brace expansion. The problems we have to overcome, as I understand it, are:
Starting with musl's fnmatch has the benefit of inheriting a simple, world-class implementation which has been relied upon and tested in practice. I know that the idea of copying code from a libc is a bit gross, but I'm not sure if there's a way to add globstar support without doing that. |
Contributor
Author
|
You mean this fnmatch implementation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@e-dant this is how much code would be necessary for a custom pattern match algorithm (without dependencies).
It's ~140 lines of code with some test cases. If something like this works for you, I could also try integrating it into the actual watcher. Not very familiar with C++, so this could probably also be done simpler or more performant.