feature symfony#17732 [DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit (ybensacq)

fabpot · fabpot · commit ff87f30f3ec4 · 2016-02-18T15:03:27.000+01:00
This PR was squashed before being merged into the 3.1-dev branch (closes symfony#17732). Discussion ---------- [DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#17701 | License | MIT Commits ------- 68c9305 [DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit
diff --git a/UPGRADE-3.1.md b/UPGRADE-3.1.md
@@ -15,6 +15,9 @@ Form
 
  * The `choices_as_values` option of the `ChoiceType` has been deprecated and
    will be removed in Symfony 4.0.
+ * Support for data objects that implements both `Traversable` and `ArrayAccess`
+   in `ResizeFormListener::preSubmit` method has been deprecated and will be
+   removed in Symfony 4.0.
 
 HttpKernel
 ----------
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -13,6 +13,8 @@ Form
 ----
 
  * The `choices_as_values` option of the `ChoiceType` has been removed.
+ * Support for data objects that implements both `Traversable` and
+   `ArrayAccess` in `ResizeFormListener::preSubmit` method has been removed
 
 HttpKernel
 ----------
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -5,6 +5,8 @@ CHANGELOG
 -----
 
  * deprecated the "choices_as_values" option of ChoiceType
+ * deprecated support for data objects that implements both `Traversable` and
+   `ArrayAccess` in `ResizeFormListener::preSubmit` method
 
 3.0.0
 -----
diff --git a/src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php b/src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
@@ -102,6 +102,10 @@ public function preSubmit(FormEvent $event)
         $form = $event->getForm();
         $data = $event->getData();
 
+        if ($data instanceof \Traversable && $data instanceof \ArrayAccess) {
+            @trigger_error('Support for objects implementing both \Traversable and \ArrayAccess is deprecated since version 3.1 and will be removed in 4.0. Use an array instead.', E_USER_DEPRECATED);
+        }
+
         if (!is_array($data) && !($data instanceof \Traversable && $data instanceof \ArrayAccess)) {
             $data = array();
         }
